fix: string date format validation #484
Conversation
|
Please make sure that this test works as expected. fast-json-stringify/test/date.test.js Line 492 in e083ca6 |
| } | ||
| return this.asString(date) | ||
| throw new Error(`The value "${date}" cannot be converted to a date-time.`) |
There was a problem hiding this comment.
What if I passed a string that fulfill date-time, date, time?
It seems like it only accept Date object after this change.
There was a problem hiding this comment.
If you pass a string it will be stringified in the asString method.
| return validateTimeFormat(date) | ||
| } | ||
| return false | ||
| keyword: 'fjs_type', |
There was a problem hiding this comment.
| keyword: 'fjs_type', | |
| keyword: 'fjs_date_type', |
I think we should try not to change this.
There was a problem hiding this comment.
@mcollina I agree, but it is a completely different meaning of this property now. It's not a date format anymore. It describes how ajv should validate custom type at all. For example, for string type, there would be not only the Date object validation but also Regexp objects and some other exceptions.
Checklist
npm run testandnpm run benchmarkand the Code of conduct