New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: standalone ajv schema #461
Conversation
Given that people complain fastify/fastify#3998 it about the This patch will remove the dependent of |
Co-authored-by: Frazer Smith <frazer.dev@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, one nit
Co-authored-by: Matteo Collina <hello@matteocollina.com>
lmk when it's ok to release |
@climba03003 Do we need to generate a standalone serializer only here? |
I would not exclude we could need to do it elsewhere too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcollina
I think it is ok to land now.
One final tweak is that it should not write ajv
to standalone script when it is not needed.
Co-authored-by: Zed <zedeus@pm.me>
Co-authored-by: Zed <zedeus@pm.me>
@climba03003 could you send the PRs needed to fastify and https://github.com/fastify/fast-json-stringify-compiler? Please update the versions everywhere. |
This PR do not need to merge immediately.
We need to test each edge case before merging this PR.
fast-json-stringify
instandalone
code.fast-json-stringify
generate custom json schema.Checklist
npm run test
andnpm run benchmark
and the Code of conduct