Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add export ErrorObject #82

Merged
merged 2 commits into from Sep 17, 2022
Merged

feat: add export ErrorObject #82

merged 2 commits into from Sep 17, 2022

Conversation

budarin
Copy link
Contributor

@budarin budarin commented Sep 16, 2022 •
edited

Export ErrorObject to support fastify PR #4283

Checklist

@Uzlopak Uzlopak requested a review from Eomm September 16, 2022 19:45
@budarin budarin mentioned this pull request Sep 17, 2022
Merged
3 tasks
mcollina
mcollina requested changes Sep 17, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test? We use tsd for typescript.

Eomm
Eomm reviewed Sep 17, 2022
View reviewed changes
index.d.ts Show resolved Hide resolved
mcollina
mcollina approved these changes Sep 17, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit b014513 into fastify:main Sep 17, 2022
@budarin budarin deleted the export-erroobject branch September 18, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Uzlopak Uzlopak Uzlopak approved these changes

@Eomm Eomm Eomm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@budarin @mcollina @Uzlopak @Eomm