-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record pystats periodically. #499
Conversation
50732da
to
21e90e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
How is this triggered?
Sorry -- I should make this a draft. The plan is this will be a weekly cron action, but I have it set to |
Thanks for working on this! This will be a big win for our workflow (I was just trying to decide if it's worth doing a local stats run today to check up on 3.12). |
This should be working now, and it would be good to get a review in case anything in the action isn't clear (@ericsnowcurrently, @brandtbucher). There is no way to fully test the part that adds results to the You can see the example output here: https://github.com/faster-cpython/ideas/suites/9543557905/artifacts/453779401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm not especially familiar with the structure and semantics of GitHub workflow configs, but what you have made sense and nothing jumped out at me as wrong. 🙂
Part of faster-cpython/tools#115