Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record pystats periodically. #499

Merged
merged 7 commits into from Nov 29, 2022
Merged

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Nov 22, 2022

Copy link
Collaborator

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

How is this triggered?

@mdboom
Copy link
Contributor Author

mdboom commented Nov 22, 2022

Sorry -- I should make this a draft. The plan is this will be a weekly cron action, but I have it set to pull_request right now so I can test it. It's broken by python/cpython#99701 at the moment.

@mdboom mdboom marked this pull request as draft November 22, 2022 17:47
@brandtbucher
Copy link
Member

Thanks for working on this! This will be a big win for our workflow (I was just trying to decide if it's worth doing a local stats run today to check up on 3.12).

@mdboom mdboom changed the title Record pystats periodically Record pystats periodically. Nov 28, 2022
@mdboom mdboom marked this pull request as ready for review November 28, 2022 16:26
@mdboom
Copy link
Contributor Author

mdboom commented Nov 28, 2022

This should be working now, and it would be good to get a review in case anything in the action isn't clear (@ericsnowcurrently, @brandtbucher). There is no way to fully test the part that adds results to the ideas repo until we merge this and let the job run -- I think we just have to merge and cross our fingers. (Pull requests don't have permissions to add files to the repo, for obvious reasons).

You can see the example output here: https://github.com/faster-cpython/ideas/suites/9543557905/artifacts/453779401

Copy link
Collaborator

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm not especially familiar with the structure and semantics of GitHub workflow configs, but what you have made sense and nothing jumped out at me as wrong. 🙂

@mdboom mdboom merged commit fca044e into faster-cpython:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants