Skip to content

Commit

Permalink
Be explicit about minimum TLS version (elastic#5674)
Browse files Browse the repository at this point in the history
  • Loading branch information
pebrc authored and fantapsody committed Jan 3, 2023
1 parent 35b6e4a commit 79f3d7e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/controller/common/http_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@ func HTTPClient(dialer net.Dialer, caCerts []*x509.Certificate, timeout time.Dur

transportConfig := http.Transport{
TLSClientConfig: &tls.Config{
RootCAs: certPool,
RootCAs: certPool,
MinVersion: tls.VersionTLS12, // this is the default as of Go 1.18 we are just restating this here for clarity.

// We use our own certificate verification because we permit users to provide their own certificates, which may not
// be valid for the k8s service URL (though our self-signed certificates are). For instance, users may use a certificate
Expand Down

0 comments on commit 79f3d7e

Please sign in to comment.