New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Assign new colors for the products in the admin area #1569
Conversation
This works for creating a new color , but we need to associate a newly created color to a dress in admin as well |
This error was caused by a Updating Rack and QAing preprod is the better option for the bug introduced by this issue. Update: updating rack will be impossible, since modern ActionPack depends on older Rack versions. I would vote on just changing the Example: we now have 230 colors on the Suggestion (though it's stupid using if Gem::Version.new(Rails::VERSION::STRING) < Gem::Version.new('4')
Rack::Utils.multipart_part_limit = 300
else
puts '------------------------------------------------------------------------------------------------------'
puts 'Rails is on its 4 version! Upgrade Rack to its latest version to solve rack/rack#814, "Too many open files"'
puts '------------------------------------------------------------------------------------------------------'
end |
ce50e62
to
77879fa
Compare
.row | ||
.col-md-3 | ||
p | ||
b SKU |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slim tip: when you have small nested tags like this you can use two points to "inline nest" them
.col-md-3 : p : b
SKU
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool tip, thanks a lot!
some screenshots and test cases are needed |
That's a very good point @namproctin. The Admin UI has been lacking tests from developer confidence that'll "simply work". As it grows, that assertion could be false. |
77879fa
to
8a22ebc
Compare
uber (~> 0.0.7) | ||
representable (3.0.0) | ||
declarative (~> 0.0.5) | ||
uber (~> 0.0.15) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, careful when upgrading major versions of other gems you're not actually using. Those could break behavior from other areas/specs. Was this upgrade intended?
👍 LGTM! 👍 There's a small comment on the Just CI complaining, probably because of fixture database. Going to prepare one and commit here. @namproctin any comments on this? |
b1d5ab7
to
f238f33
Compare
8d01077
to
5766fc5
Compare
making color deletion feature on fame_admin is wanted |
= render 'admin_ui/grid/grid_collection_filters', collection_url: product_colors_path | ||
= link_to 'Create a Color', new_product_color_path, class: 'btn btn-primary' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be 'Create a new product-color association' OR 'Add new color to product'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@namproctin's right. This isn't a "New Color Creation" action. IMO, "Add new color to product" is fine.
630d870
to
f314be1
Compare
@dmitrychekalin , freel free to This now has a full CRUD on |
https://fameandpartners.atlassian.net/browse/WEBSITE-204
Problem:
Ability to create
ProductColorValue
s on admin uiImplemented as a new form for the product colors page http://prnt.sc/att0yz. Colors (except already assigned colors for this product) are loading dynamically.
@tiagoamaro, is there a requirement to delete colors from a product?