chore(CI): pin pytest + ASGI tutorial fixes
#2233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2233 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 6931 6931
Branches 1258 1258
=========================================
Hits 6931 6931 ☔ View full report in Codecov by Sentry. |
CaselIT
reviewed
May 7, 2024
CaselIT
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that something breaks when using
testtools.TestCaseunderpytest8.2.x along the lines of pytest-dev/pytest#12263. This PR temporarily pinspytestuntil the issue is resolved upstream, or we decide on how we want to move forward with this. An alternative is to drop active support fortesttoolsaltogether: #2156.Also patched is some typing import issue in ASGI tutorial tests. The issue seems to also stem from third party packages (
fakeredis) under Python 3.10 that we had hardwired in the tox env by mistake. I'll file a followup issue, because this also means that our tutorial is not fully usable on 3.10 or older.