Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tox): drop --no-build-isolation from Cython tests #2229

Merged
merged 2 commits into from Apr 17, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Apr 14, 2024

Closes #2184

Copy link

codecov bot commented Apr 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (89bfb57) to head (81c51fd).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2229   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6931      6931           
  Branches      1258      1258           
=========================================
  Hits          6931      6931           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vytas7 vytas7 requested review from nZac, kgriffs and CaselIT April 14, 2024 11:30
@CaselIT
Copy link
Member

CaselIT commented Apr 14, 2024

I don't remember if we mentioned something also in the docs / readme regarding the build isolation

@vytas7
Copy link
Member Author

vytas7 commented Apr 17, 2024

@CaselIT you'd be right, installation docs are very outdated... I'll create a separate issue tracking this.

Edit: filed as #2232.

@vytas7 vytas7 merged commit 33e0bb3 into falconry:master Apr 17, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop --no-build-isolation in testing
2 participants