Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sync): use asyncio.Runner for async_to_sync() on py311+ #2216

Merged
merged 7 commits into from Mar 21, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Mar 20, 2024

Fixes #2178

@vytas7 vytas7 requested review from nZac, kgriffs and CaselIT March 20, 2024 16:10
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (dc8d2d4) to head (8c1e0af).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2216   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         6880      6888    +8     
  Branches      1099      1099           
=========================================
+ Hits          6880      6888    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok

falcon/util/sync.py Outdated Show resolved Hide resolved
@vytas7 vytas7 requested a review from CaselIT March 21, 2024 13:18
Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok!

@vytas7
Copy link
Member Author

vytas7 commented Mar 21, 2024

OK, merging this since we want to unblock Uvicorn gates

@vytas7 vytas7 merged commit a78cfb3 into falconry:master Mar 21, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultEventLoopPolicy.get_event_loop() is deprecated (in the case of no loop)
2 participants