Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(FAQ): add a FAQ item on shutting down wsgiref.simple_server #2203

Merged
merged 2 commits into from Jan 16, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Jan 14, 2024

Fixes #1559

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0648726) 100.00% compared to head (861fa3b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2203   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         6880      6880           
  Branches      1099      1099           
=========================================
  Hits          6880      6880           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CaselIT
CaselIT previously approved these changes Jan 15, 2024
Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think it make sense adding a note that wsgiref should not be used in prod?

I think it's documented somewhere else, so maybe not needed

@vytas7
Copy link
Member Author

vytas7 commented Jan 15, 2024

Hm, good idea, it doesn't hurt to reiterate this.

Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@vytas7 vytas7 merged commit 4910dd7 into falconry:master Jan 16, 2024
37 checks passed
@vytas7 vytas7 deleted the 1559-shutdown-server branch March 24, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way of adding a REST API call that causes falcon to cleanly shut down?
2 participants