fix: prevent pytest from collecting tests on testing.TestClient

[aryaniyaps]

Summary of Changes

prevent pytest from collecting tests on testing.TestClient

Related Issues

fixes #2147

Pull Request Checklist

This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.

• Applied changes to both WSGI and ASGI code paths and interfaces (where applicable).
• Added tests for changed code.
• Prefixed code comments with GitHub nick and an appropriate prefix.
• Coding style is consistent with the rest of the framework.
• Updated documentation for changed code.
  • Added docstrings for any new classes, functions, or modules.
  • Updated docstrings for any modifications to existing code.
  • Updated both WSGI and ASGI docs (where applicable).
  • Added references to new classes, functions, or modules to the relevant RST file under docs/.
  • Updated all relevant supporting documentation files under docs/.
  • A copyright notice is included at the top of any new modules (using your own name or the name of your organization).
  • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
• Changes (and possible deprecations) have towncrier news fragments under docs/_newsfragments/, with the file name format {issue_number}.{fragment_type}.rst. (Run towncrier --draft to ensure it renders correctly.)

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

PR template inspired by the attrs project.

[codecov]

Codecov Report

Merging #2148 (20e8eb4) into master (200a853) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2148   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         6789      6791    +2     
  Branches      1095      1095           
=========================================
+ Hits          6789      6791    +2     

Impacted Files	Coverage Δ
falcon/testing/client.py	100.00% <100.00%> (ø)
falcon/testing/test_case.py	100.00% <100.00%> (ø)

[vytas7]

Hey there, thanks for this PR, it looked good bar some extraneous whitespace that made the flake8 and blue checks fail.

However, in your latest commit you changed virtually every line of the whole codebase, we'll need to revert this one 😅

[vytas7]

Hi again, still the same problem. Your PR proposes to change 68706 lines, basically the whole codebase, while I expect this fix to consist of 2-3 lines plus maybe a newsfragment. You need to revert unrelated changes before we can proceed with this.

[aryaniyaps]

Hi again, still the same problem. Your PR proposes to change 68706 lines, basically the whole codebase, while I expect this fix to consist of 2-3 lines plus maybe a newsfragment. You need to revert unrelated changes before we can proceed with this.

I'm actually unsure on how to revert it. Maybe a new PR? or are there any commands to execute locally?

[CaselIT]

Hi again, still the same problem. Your PR proposes to change 68706 lines, basically the whole codebase, while I expect this fix to consist of 2-3 lines plus maybe a newsfragment. You need to revert unrelated changes before we can proceed with this.

I'm actually unsure on how to revert it. Maybe a new PR? or are there any commands to execute locally?

sure, feel free to close this and reopen a new PR. An alternative may be to force push on this branch applying your original change to master

[rite2hhh]

Hi again, still the same problem. Your PR proposes to change 68706 lines, basically the whole codebase, while I expect this fix to consist of 2-3 lines plus maybe a newsfragment. You need to revert unrelated changes before we can proceed with this.

I'm actually unsure on how to revert it. Maybe a new PR? or are there any commands to execute locally?

Looks like a classic CRLF (Windows) vs LF (Unix) issue

If you're using vscode look at the bottom right.

In this image it says LF, if you used a Windows system to make changes, yours probably says CRLF.
Change it back to LF. If not, find a different way to revert that and you should be good to go.

Most repos use Unix convention of LF as the end-of-line character.

See: https://stackoverflow.com/questions/1967370/git-replacing-lf-with-crlf

[vytas7]

Thanks for bringing this up @aryaniyaps! 👍
I took the liberty of cleaning whitespace and line endings, as well as adding a newsfragment.

[vytas7]

And thanks for some good tips @rite2hhh!

FWIW, I have now added .editorconfig to the master branch, so if one's editor of choice (or its plugins) supports this standard, the editor should pick up Unix line endings correctly.