Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typing): add type hints to compiled router #1944

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CaselIT
Copy link
Member

@CaselIT CaselIT commented Aug 4, 2021

This is mainly to try how cython works with pep484 types

NOTE: this is currently unmergiable, since it's not py 3.5 compatible

Gist with the compilations with cython https://gist.github.com/CaselIT/f0493d74422cce46c95c10e8abd1e4f0

this is mainly to try how cython works with pep484 types
@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #1944 (8e4adf1) into master (e255bff) will decrease coverage by 0.24%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master    #1944      +/-   ##
===========================================
- Coverage   100.00%   99.75%   -0.25%     
===========================================
  Files           63       63              
  Lines         6610     6611       +1     
  Branches      1067     1068       +1     
===========================================
- Hits          6610     6595      -15     
- Misses           0       12      +12     
- Partials         0        4       +4     
Impacted Files Coverage Δ
falcon/routing/compiled.py 98.73% <93.33%> (-1.27%) ⬇️
falcon/asgi/__init__.py 81.81% <0.00%> (-18.19%) ⬇️
falcon/util/__init__.py 95.55% <0.00%> (-4.45%) ⬇️
falcon/util/misc.py 96.64% <0.00%> (-3.36%) ⬇️
falcon/media/multipart.py 98.82% <0.00%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e255bff...8e4adf1. Read the comment docs.

@vytas7
Copy link
Member

vytas7 commented Nov 6, 2022

This should be good to revisit again once #1947 gets merged.

@vytas7 vytas7 changed the title Try typing compiled. feat(typing): add type hints to compiled router Nov 6, 2022
@vytas7
Copy link
Member

vytas7 commented Jul 8, 2023

@CaselIT Now we can continue with this one; we just need to address merge conflicts and it may possible to move this forward off Draft.

@CaselIT
Copy link
Member Author

CaselIT commented Jul 8, 2023

I'll try getting into it soonish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants