Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ASGI): assume ISO-8859-1 for ASGI headers #1914

Merged
merged 6 commits into from May 5, 2021

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented May 2, 2021

Closes #1911

@codecov
Copy link

codecov bot commented May 2, 2021

Codecov Report

Merging #1914 (7ceb7a5) into master (e1ebdb7) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1914   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6593      6610   +17     
  Branches      1065      1067    +2     
=========================================
+ Hits          6593      6610   +17     
Impacted Files Coverage Δ
falcon/asgi/_request_helpers.py 100.00% <100.00%> (ø)
falcon/asgi/request.py 100.00% <100.00%> (ø)
falcon/asgi/response.py 100.00% <100.00%> (ø)
falcon/testing/helpers.py 100.00% <100.00%> (ø)
falcon/util/misc.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ebdb7...7ceb7a5. Read the comment docs.

@vytas7
Copy link
Member Author

vytas7 commented May 2, 2021

I realized I probably need to add a couple more regression tests for the reported issue itself. Working on this now.

Edit: done now.

@vytas7 vytas7 marked this pull request as draft May 2, 2021 16:09
falcon/testing/helpers.py Show resolved Hide resolved
falcon/cyutil/misc.pyx Show resolved Hide resolved
@vytas7 vytas7 marked this pull request as ready for review May 2, 2021 17:21
@vytas7 vytas7 requested review from kgriffs and CaselIT May 2, 2021 17:24
CaselIT
CaselIT previously approved these changes May 2, 2021
tests/test_headers.py Show resolved Hide resolved
falcon/asgi/response.py Show resolved Hide resolved
@vytas7 vytas7 requested a review from kgriffs May 5, 2021 19:36
@kgriffs kgriffs merged commit a1805c8 into falconry:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assume ISO-8859-1 (instead of UTF-8) encoding for ASGI HTTP headers
3 participants