Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixGitHub #47

Closed
wants to merge 3 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion runtime/pom.xml
Expand Up @@ -19,7 +19,7 @@
<maven-bundle-plugin.version>5.1.6</maven-bundle-plugin.version>
<flatten-maven-plugin.version>1.2.7</flatten-maven-plugin.version>
<!-- java and compiler options -->
<java.version>1.8</java.version>
<java.version>8</java.version>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does not work either :-(

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.8 should be fine, what is the problem with that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my attempt to fix the problem seen in https://github.com/faktorips/faktorips.base/actions/runs/3107664233/jobs/5036022637#step:8:4050:
Error: Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) on project faktorips-valuetypes-joda: Requested toolchain specification did not match any configured toolchain: {version=1.8} -> [Help 1]

My understanding was that the actions/setup-java would set up the toolchain.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding was that the actions/setup-java would set up the toolchain.

Sadly not see actions/setup-java#276 I'll try to provide a workaround for this in #49

<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
</properties>
Expand Down