Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Reduce the time complexity of all Faker::Crypto methods #2937

Closed
wants to merge 2 commits into from
Closed

Performance: Reduce the time complexity of all Faker::Crypto methods #2937

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c8aebd
Reduce the time complexity of all Faker::Crypto methods
alextaujenis Apr 18, 2024
833a4c5
Update the time complexity of all Faker::Crypto methods
alextaujenis Apr 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 17 additions & 4 deletions lib/faker/default/crypto.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,14 @@ class << self
#
# @faker.version 1.6.4
def md5
OpenSSL::Digest::MD5.hexdigest(Lorem.characters)
# The MD5 algorithm will experience a collision much sooner
# than Lorem.characters(number: 5) will. Setting the lorem
# character number lower than the default of 255 reduces the
# time complexity of this method while still returning
# deterministically unique values. Mathematical proof:
# 4^36 < 32^16 by -1204203453131759529492480
# 5^36 > 32^16 by 13342989408752222631934449
OpenSSL::Digest::MD5.hexdigest(Lorem.characters(number: 25))
end

##
Expand All @@ -28,7 +35,9 @@ def md5
#
# @faker.version 1.6.4
def sha1
OpenSSL::Digest::SHA1.hexdigest(Lorem.characters)
# 5^36 < 40^16 by -28397757731633148193359375
# 6^36 > 40^16 by 10271475125530535546171949056
OpenSSL::Digest::SHA1.hexdigest(Lorem.characters(number: 31))
end

##
Expand All @@ -41,7 +50,9 @@ def sha1
#
# @faker.version 1.6.4
def sha256
OpenSSL::Digest::SHA256.hexdigest(Lorem.characters)
# 6^36 < 64^16 by -68913737715773802047372001280
# 7^36 > 64^16 by 2572502683345389134185479431265
OpenSSL::Digest::SHA256.hexdigest(Lorem.characters(number: 50))
end

##
Expand All @@ -54,7 +65,9 @@ def sha256
#
# @faker.version next
def sha512
OpenSSL::Digest::SHA512.hexdigest(Lorem.characters)
# 8^36 < 128^16 by -4867778304876400901747340308643840
# 9^36 > 128^16 by 17336102686404346783309651545552545
OpenSSL::Digest::SHA512.hexdigest(Lorem.characters(number: 100))
end
end
end
Expand Down