Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarking loading JSON file vs YML file #2897

Merged
merged 6 commits into from Mar 17, 2024
Merged

Benchmarking loading JSON file vs YML file #2897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
059faff
Fix#2851 Add namespace to benchmark rake task to add other tasks
salochara Jan 25, 2024
3ae7d13
[Fix:2851] Add rake task to compare loading translation times with JS…
salochara Jan 25, 2024
6db9bbe
[Fix:2851] Add es-MX.json file
salochara Jan 25, 2024
3bd86b6
[Fix:2851] Use JSON.load_file method in benchmark since that is the m…
salochara Jan 26, 2024
6b61580
Merge branch 'main' of https://github.com/faker-ruby/faker into featu…
salochara Mar 7, 2024
d79d42f
[Fix:2851] Address PR comments. Moved JSON file into test directory
salochara Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 28 additions & 9 deletions tasks/benchmark.rake
View file
Open in desktop
Expand Up @@ -5,15 +5,34 @@
require 'benchmark'
require 'faker'

desc 'Benchmarking every Faker generator'
task :benchmark do
all_methods = BenchmarkHelper.all_methods
count = all_methods.count

Benchmark.bmbm do |x|
x.report("Number of generators: #{count}") do
100.times do
all_methods.each { |method_name| eval(method_name) }
namespace :benchmark do
desc 'Benchmarking all methods'
task :all_methods do
all_methods = BenchmarkHelper.all_methods
count = all_methods.count

Benchmark.bmbm do |x|
x.report("Number of generators: #{count}") do
100.times do
all_methods.each { |method_name| eval(method_name) }
end
end
end
end

desc 'Comparing loading translations from YML vs. JSON'
task :compare_loading_yml_vs_json do
Benchmark.bmbm do |x|
x.report('YML') do
100.times do
YAML.load_file(File.expand_path("#{File.dirname(__FILE__)}/../lib/locales/es-MX.yml"))
end
end

x.report('JSON') do
100.times do
JSON.load_file("#{File.dirname(__FILE__)}/../test/fixtures/locales/es-MX.json")
end
end
end
end
Expand Down