Use rubocop-minitest to lint test suite #2556
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All offenses were auto-corrected with `bundle exec rubocop -a`. In total, there were 1824 offenses!
|
I didn't realize that somehow the auto-correction turning |
koic
added a commit
to koic/rubocop-minitest
that referenced
this pull request
Sep 6, 2022
This PR fixes an incorrect autocorrect for `Minitest/AssertMatch` when `assert` with `match` and RHS is a regexp literal. A regular expression literal must be the first argument to `assert_match`. `TypeError: no implicit conversion of Regexp into String` will occur if it is passed as the second argument. ```ruby assert_match(object, /regexp/) #=> TypeError: no implicit conversion of Regexp into String ``` This issue was found on faker-ruby/faker#2556.
8 tasks
|
This is a RuboCop Minitest bug. I'm working on this. And after RuboCop Minitest release, I'll take care of it. |
|
The issue has been resolved by efedb39. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following up on the issue #2526 and this comment from @stefannibrasil, RuboCop is now linting the test suite.
Other Information
All offenses were auto-corrected with
bundle exec rubocop -a.In total, there were 1824 offenses! While this is huge and hard to review, I see a benefit in being consistent in how tests are written. This is now enforced by RuboCop.