Re-add the Faker::Internet.base64 method
#2378
Conversation
|
@psibi please verify. Thanks |
| # #=> "r_hbZ2DSD-ZACzZT" | ||
| # @example | ||
| # Faker::Internet.base64(length: 4, padding: true, urlsafe: false) | ||
| # #=> "x1/R=" |
There was a problem hiding this comment.
Can you add faker.version since the 2.11.0 series (https://github.com/faker-ruby/faker/blob/master/CHANGELOG.md#v2110-2020-03-24) except the latest one where it was removed mistakely ?
There was a problem hiding this comment.
Like this @faker.version 2.11.0 here?
There was a problem hiding this comment.
@psibi added the faker.version do check if it's the appropriate one :)
There was a problem hiding this comment.
Can you check if it's available in v2.19.0 ? (If it's not, probably you can add that information in the docs here)
|
Can you please update this fix to 2.19.0? |
|
Hi @vbrazo @connorshea thanks for the great work on the gem. What are your plans to release a new version that includes these changes? |
|
I don't have the ability to cut new releases, so it'd be up to whenever @vbrazo has time to run a new release :) |
* Re-add the `Faker::Internet.base64` method * add since 2.11.0
#2375
Description:
This PR re-adds the
Faker::Internet.base64method which was accidentally removed during the conflict resolution in#1730.