Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added more science examples #2369

Merged
merged 7 commits into from Aug 19, 2021
Merged

Added more science examples #2369

merged 7 commits into from Aug 19, 2021

Conversation

itay-grudev
Copy link
Contributor

@itay-grudev itay-grudev commented Aug 12, 2021

Description:

Adds a list of generic science names that can be filtered like:

Faker::Science.science #=> "Space science"
Faker::Science.science(:natural, :applied) #=> "Engineering"
Faker::Science.science(:formal, :applied) #=> "Computer Science"

Adds a list of science modifiers words that can used like:

Faker::Science.modifier #=> "Quantum"
Faker::Science.modifier #=> "Superconductive"

Adds a list of science tools that can include modifiers to generate more diverse data, although not guaranteed to be real:

Faker::Science.tool #=> "Superconductive Microcentrifuge"
Faker::Science.tool #=> "Portable Cryostat"
Faker::Science.tool #=> "Quantum Spectrophotometer"
Faker::Science.tool(simple: true) #=> "Microcentrifuge"

lib/faker/default/science.rb Show resolved Hide resolved
lib/faker/default/science.rb Show resolved Hide resolved
lib/faker/default/science.rb Show resolved Hide resolved
lib/faker/default/science.rb Show resolved Hide resolved
lib/faker/default/science.rb Show resolved Hide resolved
lib/faker/default/science.rb Outdated Show resolved Hide resolved
Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall the changes LGTM except some minor comments. That being said, I would wait for someone else to review the Ruby API additions as I'm not the right person to review that.

lib/faker/default/science.rb Outdated Show resolved Hide resolved
lib/faker/version.rb Outdated Show resolved Hide resolved
@itay-grudev
Copy link
Contributor Author

@psibi @koic Done.

@psibi psibi merged commit 30e5215 into faker-ruby:master Aug 19, 2021
@psibi
Copy link
Member

psibi commented Aug 19, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants