Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stock_market to Faker::Finance #2359

Merged
merged 1 commit into from Jul 13, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions doc/default/finance.md
Expand Up @@ -16,4 +16,7 @@ Faker::Finance.vat_number(country: 'ZA') #=> "ZA79494416181"
Faker::Finance.ticker #=> "AMZN"
## Supported: NASDAQ, NYSE
Faker::Finance.ticker('NASDAQ') #=> "GOOG"

# Random stock market
Faker::Finance.stock_market #=> "NASDAQ"
```
13 changes: 13 additions & 0 deletions lib/faker/default/finance.rb
Expand Up @@ -84,6 +84,19 @@ def ticker(*markets)
rescue I18n::MissingTranslationData
raise ArgumentError, "Could not find market named #{market}"
end

##
# Returns a randomly-selected stock market.
#
# @return [String]
#
# @example
# Faker::Finance.stock_market #=> 'NASDAQ'
#
# @faker.version next
def stock_market
fetch('finance.stock_market')
end
end
end
end
21 changes: 21 additions & 0 deletions lib/locales/en/finance.yml
Expand Up @@ -164,3 +164,24 @@ en:
- V
- BRK.B
- MA
stock_market:
- NYSE
- NASDAQ
- SSE
- HKEX
- JPX
- SZSE
- LSE
- TSX
- NSE-INDIA
- FSX
- TADAWUL
- OMXC-COPENHAGEN
- KRX
- BSE-BOMBAY
- SIX
- EURONEXT-PARIS
- TWSE
- ASX
- JSE
- BOVESPA
4 changes: 4 additions & 0 deletions test/faker/default/test_faker_finance.rb
Expand Up @@ -41,4 +41,8 @@ def test_ticker_with_valid_params
ticker_return = Faker::Finance.ticker('nyse')
assert Faker::Base.fetch_all('finance.ticker.nyse').join(', ').include?(ticker_return)
end

def test_stock_market
assert Faker::Finance.stock_market.match(/\w+/)
end
end