Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Faker::TvShows::TheOfficeOriginal #2342

Closed
wants to merge 1 commit into from

Conversation

tardate
Copy link

@tardate tardate commented Jun 24, 2021

Issue#

No-Story

Description:

Because, you know, I saw Faker::TvShows::TheOffice get added yesterday in #2320 and couldn't resist placing a tombstone for the original (although selecting SFW quotes proved a little more difficult than I expected/remembered!). As Ricky Gervais himself has said:

He was a jobbing actor, career not going that well if I'm being perfectly honest, who got his big break when I cast him in a show called 'The Office.' He is now leaving that show, and killing a cash cow for both of us. Please welcome the wonderful Tina Fey, and the ungrateful Steve Carell!”

because, you know, I saw Faker::TvShows::TheOffice get added yesterday;-)
Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly nervous about adding multiple similar like modules, Instead can we have a single module with a single yaml file but with different entries for various variations: https://en.wikipedia.org/wiki/The_Office#Counterparts

I guess in the new setup, the code will look like this:

Faker::TvShows::TheOffice.character_uk

@itay-grudev
Copy link
Contributor

Maybe this belongs in the Faker::TvShows sister project.

@psibi
Copy link
Member

psibi commented Aug 19, 2021

I'm not sure how maintained that sister project is, and I'm fine with this residing in this package. But I think this should be under a single namespace instead of having various different variations and module.

@fakefarm
Copy link

fakefarm commented Sep 7, 2021

This is great!

@stefannibrasil
Copy link
Contributor

Hey there. In an effort to lighten our load as maintainers and be able to serve you better in the future, the faker-ruby team is working on cleaning out the cobwebs in this repo by pruning the backlog. As there are few of us, there are a lot of items that will simply never earn our attention in a reasonable time frame, and rather than giving you an empty promise, we think it makes more sense to focus on more recent issues. That means, unfortunately, that we must close this PR.

Don't take this the wrong way: our aim is not to diminish the effort people have made or dismiss problems that have been raised.

If you feel that we should reopen this PR, please do the following first:

  • rebase with master to fix any conflicts
  • verify this contribution is still relevant (i.e. hasn't been implemented/solved yet)
  • run tests again

Then please let us know so that we can re-prioritize it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants