Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci for es-AR #2317

Merged
merged 2 commits into from May 7, 2021
Merged

Conversation

yujideveloper
Copy link
Contributor

No-Story

Description:

I fixed failing ci.

example:

===============================================================================
Failure: test_es_ar_football_coach(TestEsArLocale): <nil> is not true.
/home/runner/work/faker/faker/test/test_es_ar_locale.rb:147:in `test_es_ar_football_coach'
     144:   end
     145: 
     146:   def test_es_ar_football_coach
  => 147:     assert Faker::Sports::Football.coach.match(@name_with_nickname_pattern)
     148:   end
     149: 
     150:   def test_es_ar_football_competition
===============================================================================

/pat/u sets encoding of regexp literal to UTF-8. it is not set character set option.
ref. https://github.com/k-takata/Onigmo/blob/dd8a18af5c2f2871104b1bdbf3bbb597ec9e4665/doc/RE#L254-L257

@marcelobarreto
Copy link
Member

Can I merge this one @yujideveloper ?

@yujideveloper
Copy link
Contributor Author

@marcelobarreto Yes, this is ready.

@marcelobarreto marcelobarreto merged commit 9397e3f into faker-ruby:master May 7, 2021
@marcelobarreto
Copy link
Member

Done, thanks 👍

@yujideveloper yujideveloper deleted the fix/ci-for-es-ar branch May 7, 2021 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants