Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add birds #2299

Merged
merged 19 commits into from Apr 21, 2021
Merged

Add birds #2299

merged 19 commits into from Apr 21, 2021

Commits on Apr 13, 2021

  1. added tests for all simple bird look-ups

    @brotherjack
    brotherjack committed Apr 13, 2021
    Copy the full SHA
    5449ac5 View commit details
    Browse the repository at this point in the history

  2. added bird words (bird is the word)

    @brotherjack
    brotherjack committed Apr 13, 2021
    Copy the full SHA
    d3960a7 View commit details
    Browse the repository at this point in the history

  3. added birds!

    @brotherjack
    brotherjack committed Apr 13, 2021
    Copy the full SHA
    1a98283 View commit details
    Browse the repository at this point in the history

  4. added tests for plausible and implausible common names for birds and … 

    …correcting tests for adjectives and common_name roots
    @brotherjack
    brotherjack committed Apr 13, 2021
    Copy the full SHA
    51ecf8a View commit details
    Browse the repository at this point in the history

  5. added .plausible_common_name and .implausible_common_name and made .c… 

    …ommon_name string be lowercase
    @brotherjack
    brotherjack committed Apr 13, 2021
    Copy the full SHA
    3ae6766 View commit details
    Browse the repository at this point in the history

  6. added documentation of bird methods

    @brotherjack
    brotherjack committed Apr 13, 2021
    Copy the full SHA
    714368b View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2021

  1. corrected Rubocop offenses and made test failures on #test_plausible_… 

    …common_names and #test_implausible_common_names more clear
    @brotherjack
    brotherjack committed Apr 14, 2021
    Copy the full SHA
    1dad858 View commit details
    Browse the repository at this point in the history

  2. fixed TestFakerCreatureBird#test_plausible_common_names to allow for … 

    …names like "Painted bunting"
    @brotherjack
    brotherjack committed Apr 14, 2021
    Copy the full SHA
    a39f9ba View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Koichi ITO <koic.ito@gmail.com>
    @brotherjack @koic
    brotherjack and koic committed Apr 18, 2021
    Copy the full SHA
    28e2682 View commit details
    Browse the repository at this point in the history

  2. added a test for #order_with_common_names

    @brotherjack
    brotherjack committed Apr 18, 2021
    Copy the full SHA
    f22159c View commit details
    Browse the repository at this point in the history

  3. modified list to allow for matching common names to orders

    @brotherjack
    brotherjack committed Apr 18, 2021
    Copy the full SHA
    2fba0aa View commit details
    Browse the repository at this point in the history

  4. tests for new versions of Faker::Creature::Bird #order_with_common_na… 

    …mes and #common_name accepts a parameter for the order to restrict on
    @brotherjack
    brotherjack committed Apr 18, 2021
    Copy the full SHA
    99a7ff4 View commit details
    Browse the repository at this point in the history

  5. added tests to make sure that Faker::Creature::Bird #common_name and … 

    …#order_with_common_names work properly
    @brotherjack
    brotherjack committed Apr 18, 2021
    Copy the full SHA
    95fc715 View commit details
    Browse the repository at this point in the history

  6. corrected Faker::Creature::Bird #order_with_common_name and made #com… 

    …mon_name more robust when passed a bad parameter
    @brotherjack
    brotherjack committed Apr 18, 2021
    Copy the full SHA
    824072f View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2021

  1. changed @faker.version to correct next version

    @brotherjack
    brotherjack committed Apr 19, 2021
    Copy the full SHA
    fdb504f View commit details
    Browse the repository at this point in the history

  2. corrected rubocop offenses

    @brotherjack
    brotherjack committed Apr 19, 2021
    Copy the full SHA
    5288678 View commit details
    Browse the repository at this point in the history

  3. updated documentation

    @brotherjack
    brotherjack committed Apr 19, 2021
    Copy the full SHA
    cb1403d View commit details
    Browse the repository at this point in the history

  4. added additional silly - management apologizes for the insufficient i… 

    …rreverance of previous birb offerings
    @brotherjack
    brotherjack committed Apr 19, 2021
    Copy the full SHA
    9dcf769 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Fix typo in documentation doc/creature/bird.md 

    Co-authored-by: Koichi ITO <koic.ito@gmail.com>
    @brotherjack @koic
    brotherjack and koic committed Apr 20, 2021
    Copy the full SHA
    fa3cc07 View commit details
    Browse the repository at this point in the history