Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two generators to Faker::Science #2175

Merged
merged 5 commits into from Apr 16, 2021

Conversation

RubyHuntsman
Copy link
Contributor

No-Story

Description:

I added element_state and element_subcategory do Science. I also improved the apperance of yml file.

- Gas
- Liquid
- Solid
- Unknown
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plasma can probably be added here as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course plasma 😅

@koic koic merged commit afd7680 into faker-ruby:master Apr 16, 2021
@koic
Copy link
Member

koic commented Apr 16, 2021

Thanks!

@RubyHuntsman RubyHuntsman deleted the science-improvements branch April 16, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants