Faker::Config can be a Module rather than a Class #2167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amatsuda
force-pushed
the
config_as_a_module
branch
from
c5d44d7
to
4d65fe6
Compare
|
Just rebased against master and resolved the conflict with #2169 |
amatsuda
force-pushed
the
config_as_a_module
branch
from
4d65fe6
to
09cc66e
Compare
vbrazo
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue#
No-StoryDescription:
Here's a dead simple one line patch.
No one creates an instance of
Faker::Config. No one inherits from this class.So this "class" is indeed nothing but just a Module.