New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup books. Add Fantasy::Tolkien to README. #2154
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Faker::Fantasy::Tolkien | ||
|
|
||
| ```ruby | ||
| # Any character from the entire Tolkien legendarium | ||
| Faker::Fantasy::Tolkien.character #=> "Bungo Baggins" | ||
|
|
||
| # Any location from the entire Tolkien legendarium | ||
| Faker::Fantasy::Tolkien.location #=> "Minas Morgul" | ||
|
|
||
| # Any poem title from the entire Tolkien legendarium | ||
| Faker::Fantasy::Tolkien.poem #=> "Fifteen birds in five fir trees" | ||
|
|
||
| # Any race from the entire Tolkien legendarium | ||
| Faker::Fantasy::Tolkien.race #=> "Ents" | ||
| ``` |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does
Fantasydo and why do we need a new namespace?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Came in with the new
Faker::Fantasy::Tolkien. Since LotR and the Hobbit are equally popular as both movies and books, it didn't really make sense for that stuff to be in either. Since Tolkien is often attributed to being the grandfather of the modern fantasy world, I thought it was fitting to create a new namespace for it there.We can alias some of the other fantasy stuff into Fantasy later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantasy was the new namespace I was asked to add in PR #2152 to consolidate and normalize the existing Tolkien generators (
Movies::HobbitandMovies::LordOfTheRings). The quotes section in these 'movie' generators betray their origin as books.