Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: BIC Collission (Issue 1907) #2037

Merged
merged 5 commits into from Jun 6, 2020
Merged

Bug Fix: BIC Collission (Issue 1907) #2037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6c0329e
Increase the BIC code pool in bank.yml
jremes-foss Jun 6, 2020
26f3829
Add unit test to cover this bug, but collission still happens.
jremes-foss Jun 6, 2020
9265f73
Change Faker::Bank to @tester
jremes-foss Jun 6, 2020
cadf3d6
Increase pool and decrease the test sample
jremes-foss Jun 6, 2020
0532405
Final fixes for RuboCop
jremes-foss Jun 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/locales/en/bank.yml
View file
Open in desktop
Expand Up @@ -25,7 +25,7 @@ en:
faker:
bank:
name: ["UBS CLEARING AND EXECUTION SERVICES LIMITED", "ABN AMRO CORPORATE FINANCE LIMITED", "ABN AMRO FUND MANAGERS LIMITED", "ABN AMRO HOARE GOVETT SECURITIES", "ABN AMRO HOARE GOVETT CORPORATE FINANCE LTD.", "ALKEN ASSET MANAGEMENT", "ALKEN ASSET MANAGEMENT", "ABN AMRO HOARE GOVETT LIMITED", "AAC CAPITAL PARTNERS LIMITED", "ABBOTSTONE AGRICULTURAL PROPERTY UNIT TRUST", "ABN AMRO QUOTED INVESTMENTS (UK) LIMITED", "ABN AMRO MEZZANINE (UK) LIMITED", "ABBEY LIFE", "SANTANDER UK PLC", "OTKRITIE SECURITIES LIMITED", "ABC INTERNATIONAL BANK PLC", "ALLIED BANK PHILIPPINES (UK) PLC", "ABU DHABI ISLAMIC BANK", "ABG SUNDAL COLLIER LIMITED", "PGMS (GLASGOW) LIMITED", "ABINGWORTH MANAGEMENT LIMITED", "THE ROYAL BANK OF SCOTLAND PLC (FORMER RBS NV)"]
swift_bic: ["AACCGB21", "AACNGB21", "AAFMGB21", "AAHOGB21", "AAHVGB21", "AANLGB21", "AANLGB2L", "AAOGGB21", "AAPEGB21", "AAPUGB21", "AAQIGB21", "ABAZGB21", "ABBEGB21", "ABBYGB2L", "ABCCGB22", "ABCEGB2L", "ABCMGB21", "ABDIGB21", "ABECGB21", "ABFIGB21", "ABMNGB21", "ABNAGB21VOC" ]
swift_bic: ["AACCGB21", "AACNGB21", "AAFMGB21", "AAHOGB21", "AAHVGB21", "AANLGB21", "AANLGB2L", "AAOGGB21", "AAPEGB21", "AAPUGB21", "AAQIGB21", "ABAZGB21", "ABBEGB21", "ABBYGB2L", "ABCCGB22", "ABCEGB2L", "ABCMGB21", "ABDIGB21", "ABECGB21", "ABFIGB21", "ABMNGB21", "ABNAGB21VOC", "ANTSGB2LXXX", "ANTSGB2LCHA", "UBKLGB2LXXX", "UBKLGB2LBAK", "AKBKGB22XXX", "ALEIGB22TSY", "AIBKGB2XTSY", "ASTPGB2LXXX", "MORLGB2LSMK", "BSABGB2LXXX", "BSCHGB2LEQU", "BOFAGB4TLTR", "BARBGB2LTOO", "BKCHGB2UXXX", "BCYPGB2LCSB", "BARBGB2LLEI", "BOFAGB3SSWI", "BOFAGB4TCCD", "BOFAGB4TCDO", "BOFAGB4TIPA", "BOFAGB4TLFS", "BOFAGB22OF2", "BOFAGB22SCP", "BOFAGB22XXX", "BOFAGB22CLS", "BOFAGB22SEC", "BARBGB2LBIR", "BARBGB2LHAR", "BARBGB2LKEN", "BARBGB2LKIL", "BARBGB2LWEM", "BARBGB2LMAN", "BARBGB2LSOU", "BRBAGB2LXXX", "BCEYGB2LXXX", "BKCHGB2LXXX", "BCYPGB2LBBB", "BCYPGB2LXXX", "BCYPGB2LCBB", "BCYPGB2LHGB", "BCYPGB2LHHB", "BCYPGB2LPGB", "BCYPGB2LSSB", "BCYPGB2LMBB"]
iban_details:
# Data from http://www.tbg5-finance.org/?ibandocs.shtml/
ad:
Expand Down
9 changes: 9 additions & 0 deletions test/faker/default/test_faker_bank.rb
View file
Open in desktop
Expand Up @@ -46,6 +46,15 @@ def test_swift_bic
assert @tester.swift_bic.match(/(\w+\.? ?){2,3}/)
end

# This test makes sure there are no collissions in BIC number pool
def test_swift_bic_collission
10.times do
samplebic1 = @tester.swift_bic
samplebic2 = @tester.swift_bic
refute_equal samplebic1, samplebic2
end
end

def test_iban_default
assert @tester.iban.match(/[A-Z]{4}\d{14}/)
end
Expand Down