Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate HeroesOfTheStorm.class #2031

Merged
merged 1 commit into from Jun 6, 2020
Merged

Deprecate HeroesOfTheStorm.class #2031

merged 1 commit into from Jun 6, 2020

Commits on Jun 5, 2020

  1. Deprecate HeroesOfTheStorm.class 

    Fixes faker-ruby#2006.

This PR solves an issue of overriding Ruby's built-in `Object#class` method.

I'd like to maintain `HeroesOfTheStorm.class`'s behavior for
a period of time.
But I chose to make a breaking change because it differs from
the expected behavior for built-in `Object#class` method.

I think that the warning for `HeroesOfTheStorm.class`
will be removed in near future.
    @koic
    koic committed Jun 5, 2020
    Configuration menu
    Copy the full SHA
    d3e8929 View commit details
    Browse the repository at this point in the history