Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add general documentation for Faker::Blood #2030

Merged
merged 3 commits into from Jun 3, 2020

Conversation

jbergenson
Copy link
Contributor

on-behalf-of: @Cofense oss@cofense.com

#2023

Description:

Adds a new md file for general documentation of the Faker::Blood class introduced in 2.12.0.

on-behalf-of: @Cofense <oss@cofense.com>
@jbergenson jbergenson mentioned this pull request Jun 3, 2020
doc/default/blood.md Outdated Show resolved Hide resolved
doc/default/blood.md Outdated Show resolved Hide resolved
Copy link
Member

@vbrazo vbrazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @koic suggestion. Other than that, I think it looks good.

Thanks 👍

jbergenson and others added 2 commits June 3, 2020 12:05
Co-authored-by: Koichi ITO <koic.ito@gmail.com>
Co-authored-by: Koichi ITO <koic.ito@gmail.com>
@jbergenson
Copy link
Contributor Author

Thx all, suggestions have been committed to branch.

@koic koic merged commit 76cafab into faker-ruby:master Jun 3, 2020
@koic
Copy link
Member

koic commented Jun 3, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants