Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YARD docs for Date, Time, and Number #1753

Merged
merged 6 commits into from Sep 22, 2019
Merged

Add YARD docs for Date, Time, and Number #1753

merged 6 commits into from Sep 22, 2019

Commits on Sep 19, 2019

  1. Add YARD docs for Faker::Time.

    @connorshea
    connorshea committed Sep 19, 2019
    Copy the full SHA
    efc976f View commit details
    Browse the repository at this point in the history

  2. Add YARD docs for Faker::Date.

    @connorshea
    connorshea committed Sep 19, 2019
    Copy the full SHA
    d96fd63 View commit details
    Browse the repository at this point in the history

  3. Oops, forgot return types for Date and Time.

    @connorshea
    connorshea committed Sep 19, 2019
    Copy the full SHA
    cdbf06f View commit details
    Browse the repository at this point in the history

  4. Add YARD docs for Faker::Number.

    @connorshea
    connorshea committed Sep 19, 2019
    Copy the full SHA
    5a2314c View commit details
    Browse the repository at this point in the history

  5. Update some YARD docs to resolve feedback. 

    Fix some phrasing, add missing version tags, fix a Rubocop warning by
disabling the cop, and clarify the possible values for period in
Faker::Time.
    @connorshea
    connorshea committed Sep 19, 2019
    Copy the full SHA
    711843b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. Update returned date object in examples.

    @connorshea
    connorshea committed Sep 20, 2019
    Copy the full SHA
    44efce8 View commit details
    Browse the repository at this point in the history