Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faker::Movies::GratefulDead => Faker::Music::GratefulDead #1549

Merged
merged 1 commit into from Feb 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions doc/unreleased/music/grateful_dead.md
@@ -0,0 +1,8 @@
# Faker::Music::GratefulDead


```ruby
Faker::Music::GratefulDead.player #=> "Jerry Garcia"

Faker::Music::GratefulDead.song #=> "Cassidy"
```
22 changes: 22 additions & 0 deletions lib/faker/deprecate/unreleased/movies/grateful_dead.rb
@@ -0,0 +1,22 @@
# frozen_string_literal: true

module Faker
module Movies
class GratefulDead < Base
class << self
extend Gem::Deprecate

def player
Faker::Music::GratefulDead.player
end

def song
Faker::Music::GratefulDead.song
end

deprecate :player, 'Faker::Music::GratefulDead.player', 2019, 04
deprecate :song, 'Faker::Music::GratefulDead.song', 2019, 04
end
end
end
end
@@ -1,7 +1,9 @@
# frozen_string_literal: true

require_relative 'music'

module Faker
module Movies
class Music
class GratefulDead < Base
class << self
def player
Expand Down
3 changes: 2 additions & 1 deletion lib/locales/en/grateful_dead.yml
Expand Up @@ -44,4 +44,5 @@ en:
"The Music Never Stopped",
"Black Muddy River",
"Looks Like Rain",
"Bird Song"]
"Bird Song",
"Cassidy"]
Expand Up @@ -2,7 +2,7 @@

require_relative '../../test_helper'

class TestFakerMoviesGratefulDead < Test::Unit::TestCase
class TestDeprecateFakerMoviesGratefulDead < Test::Unit::TestCase
def setup
@tester = Faker::Movies::GratefulDead
end
Expand Down
17 changes: 17 additions & 0 deletions test/faker/music/test_faker_grateful_dead.rb
@@ -0,0 +1,17 @@
# frozen_string_literal: true

require_relative '../../test_helper'

class TestFakerGratefulDead < Test::Unit::TestCase
def setup
@tester = Faker::Music::GratefulDead
end

def test_player
assert @tester.player.match(/\w/)
end

def test_song
assert @tester.song.match(/\w/)
end
end
2 changes: 1 addition & 1 deletion unreleased_README.md
Expand Up @@ -247,7 +247,6 @@ gem 'faker', :git => 'https://github.com/stympy/faker.git', :branch => 'master'
- [Faker::Movie](doc/unreleased/movies/movie.md)
- [Faker::Movies::BackToTheFuture](doc/unreleased/movies/back_to_the_future.md)
- [Faker::Movies::Ghostbusters](doc/unreleased/movies/ghostbusters.md)
- [Faker::Movies::GratefulDead](doc/unreleased/movies/grateful_dead.md)
- [Faker::Movies::HarryPotter](doc/unreleased/movies/harry_potter.md)
- [Faker::Movies::HitchhikersGuideToTheGalaxy](doc/unreleased/movies/hitchhikers_guide_to_the_galaxy.md)
- [Faker::Movies::Hobbit](doc/unreleased/movies/hobbit.md)
Expand All @@ -259,6 +258,7 @@ gem 'faker', :git => 'https://github.com/stympy/faker.git', :branch => 'master'

### Music
- [Faker::Music](doc/unreleased/music/music.md)
- [Faker::Music::GratefulDead](doc/music/grateful_dead.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also remove the entry under Movies

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

- [Faker::Music::Phish](doc/unreleased/music/phish.md)
- [Faker::Music::RockBand](doc/unreleased/music/rock_band.md)
- [Faker::Music::UmphreysMcgee](doc/unreleased/music/umphreys_mcgee.md)
Expand Down