Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli interface for faker #14

Closed
wants to merge 11 commits into from
Closed

Cli interface for faker #14

wants to merge 11 commits into from

Conversation

shapeshed
Copy link

I've added a CLI for faker. Cucumber tests are there to match the test unit coverage.

@stympy
Copy link
Contributor

stympy commented Sep 5, 2011

Thanks for the pull request, and sorry for the delay in getting back to you on it. I'm getting a lot of warnings from thor when running the tests against the latest master. If you could update your code to clobber the warnings I'll be happy to do the merge. And I'll even do it faster, this time. :)

@shapeshed
Copy link
Author

I fixed a few things resulting from dependency upgrades since the initial pull request but I'm still getting the warnings from Thor

/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/util.rb:158: warning: `*' interpreted as argument prefix
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor.rb:282: warning: instance variable @long_desc not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor.rb:282: warning: instance variable @long_desc not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized

This looks like a known issue with Thor. I get the warnings on ree, 1.9.2 & 1.9.3

I guess it will be difficult to merge this pull request until the warnings are fixed upstream.

@stympy
Copy link
Contributor

stympy commented Sep 15, 2012

Updating to the latest thor fixes the warnings, but now running the bin gives me this:

Illegal instruction: 4

@stympy
Copy link
Contributor

stympy commented Sep 15, 2012

Ah, apparently that error happened with bundler clobber the bin/faker file.

@vbrazo
Copy link
Member

vbrazo commented May 18, 2018

@shapeshed Are you still interested in finishing this idea? If so, please rebase with master, fix the Rubocop violations and push it. Otherwise, I think we should assign this task to another contributor or close this PR.

@vbrazo
Copy link
Member

vbrazo commented Jun 9, 2018

This PR was moved to #1278

@vbrazo vbrazo closed this Jun 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants