New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cli interface for faker #14
Conversation
Thanks for the pull request, and sorry for the delay in getting back to you on it. I'm getting a lot of warnings from thor when running the tests against the latest master. If you could update your code to clobber the warnings I'll be happy to do the merge. And I'll even do it faster, this time. :) |
I fixed a few things resulting from dependency upgrades since the initial pull request but I'm still getting the warnings from Thor /Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/util.rb:158: warning: `*' interpreted as argument prefix
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor.rb:282: warning: instance variable @long_desc not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor.rb:282: warning: instance variable @long_desc not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized
/Users/george/.rvm/gems/ruby-1.9.2-p290@faker/gems/thor-0.14.6/lib/thor/base.rb:528: warning: instance variable @no_tasks not initialized This looks like a known issue with Thor. I get the warnings on ree, 1.9.2 & 1.9.3 I guess it will be difficult to merge this pull request until the warnings are fixed upstream. |
Updating to the latest thor fixes the warnings, but now running the bin gives me this:
|
Ah, apparently that error happened with bundler clobber the bin/faker file. |
@shapeshed Are you still interested in finishing this idea? If so, please rebase with |
a359def
to
a5d7731
Compare
This PR was moved to #1278 |
I've added a CLI for faker. Cucumber tests are there to match the test unit coverage.