Fix I18n 0.9.3 compatibility #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vbrazo I would be very happy to do so, but at the moment I'm without my development machine 😢 I will let you know ASAP |
vbrazo
force-pushed
the
master
branch
2 times, most recently
from
1dbe328
to
e1e54c6
Compare
tagliala
force-pushed
the
fix-i18n-support
branch
from
a8e0a6c
to
df6e565
Compare
|
@vbrazo rebased and ready for review |
vbrazo
force-pushed
the
master
branch
3 times, most recently
from
a359def
to
a5d7731
Compare
|
Can we get this merged? The naming issue seems unrelated to this PR. |
Starting from version 0.9.3, I18n doesn't store translations for locales not set as available. This change set locales as available before storing translations. Fix: faker-ruby#1132 Ref: ruby-i18n/i18n#391
tagliala
force-pushed
the
fix-i18n-support
branch
from
df6e565
to
455db79
Compare
davidmorton0
pushed a commit
to davidmorton0/faker
that referenced
this pull request
Jul 12, 2021
Starting from version 0.9.3, I18n doesn't store translations for locales not set as available. This change set locales as available before storing translations. Fix: faker-ruby#1132 Ref: ruby-i18n/i18n#391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from version 0.9.3, I18n doesn't store translations for locales
not set as available.
This change set locales as available before storing translations.
Fix: #1132
Ref: ruby-i18n/i18n#391