Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add Faker::Internet.base64 #2375

Closed
scottfirestone opened this issue Aug 24, 2021 · 4 comments
Closed

Re-add Faker::Internet.base64 #2375

scottfirestone opened this issue Aug 24, 2021 · 4 comments
Assignees
@ashishra0

Comments

@scottfirestone
Copy link

Is your feature request related to a problem? Please describe.
The base64 method looks to have been removed from Faker::Internet class with this PR: #1730. This removal is breaking specs in my application.

I don't see any reasoning behind this removal stated in the PR and am curious why it was removed.
@FraDim
Copy link

FraDim commented Aug 25, 2021

@ashishra0 @psibi: It seems that, during #1730's conflict resolution, we lost the .base64 method.

@ashishra0
Copy link
Contributor

ashishra0 commented Aug 25, 2021 •
edited

Oh no, I am so sorry @FraDim, @scottfirestone. This was a mistake on my part, how do you propose we fix this?

@psibi
Copy link
Member

psibi commented Aug 26, 2021

Just send an additional PR fixing it.

@ashishra0
Copy link
Contributor

Okay, can you assign this to me? I'll have the PR by eod

@ashishra0 ashishra0 mentioned this issue Aug 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashishra0 ashishra0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@FraDim @thdaraujo @psibi @scottfirestone @ashishra0