Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail with i18n version 0.9.3 #1132

Closed
tagliala opened this issue Jan 27, 2018 · 0 comments
Closed

Tests fail with i18n version 0.9.3 #1132

tagliala opened this issue Jan 27, 2018 · 0 comments
Labels
🐞 Issue: Bug

Comments

@tagliala
Copy link
Contributor

How to replicate:

  1. clone repo
  2. update gems (you should see Using i18n 0.9.3 (was 0.9.1))
  3. run tests

The reason should be ruby-i18n/i18n#391

I'm trying to submit a PR
tagliala added a commit to tagliala/faker that referenced this issue Jan 27, 2018
@tagliala
Fix I18n 0.9.3 compatibility
a8e0a6c 
Starting from version 0.9.3, I18n doesn't store translations for locales
not set as available.

This change set locales as available before storing translations.

Fix: faker-ruby#1132

Ref: ruby-i18n/i18n#391
@tagliala tagliala mentioned this issue Jan 27, 2018
Merged
@tagliala tagliala changed the title Failure with i18n version 0.9.3 Tests fail with i18n version 0.9.3 Jan 27, 2018
tagliala added a commit to tagliala/faker that referenced this issue May 20, 2018
@tagliala
Fix I18n 0.9.3 compatibility
df6e565 
Starting from version 0.9.3, I18n doesn't store translations for locales
not set as available.

This change set locales as available before storing translations.

Fix: faker-ruby#1132

Ref: ruby-i18n/i18n#391
tagliala added a commit to tagliala/faker that referenced this issue Jun 21, 2018
@tagliala
Fix I18n 0.9.3 compatibility
455db79 
Starting from version 0.9.3, I18n doesn't store translations for locales
not set as available.

This change set locales as available before storing translations.

Fix: faker-ruby#1132

Ref: ruby-i18n/i18n#391
stympy pushed a commit that referenced this issue Jun 21, 2018
@tagliala @stympy
Fix I18n 0.9.3 compatibility (#1133)
b5e25b1 
Starting from version 0.9.3, I18n doesn't store translations for locales not set as available.

This change set locales as available before storing translations.

Fix: #1132

Ref: ruby-i18n/i18n#391
davidmorton0 pushed a commit to davidmorton0/faker that referenced this issue Jul 12, 2021
@tagliala @stympy
Fix I18n 0.9.3 compatibility (faker-ruby#1133)
cc04a36 
Starting from version 0.9.3, I18n doesn't store translations for locales not set as available.

This change set locales as available before storing translations.

Fix: faker-ruby#1132

Ref: ruby-i18n/i18n#391
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 Issue: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tagliala @vbrazo