Fix invalid IANA time zone identifier for Atlantic/Cape_Verde (#2927)

* Add failing test * Replace Atlantic/Cabo_Verde with the valid IANA time zone identifier Atlantic/Cape_Verde in en.faker.address.time_zone
faker-ruby · Apr 19, 2024 · 8f01a57 · 8f01a57
1 parent 6db1e8f
commit 8f01a57
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/Gemfile b/Gemfile
@@ -15,4 +15,5 @@ gem 'rubocop-rake', '0.6.0'
 gem 'simplecov', '0.22.0'
 gem 'test-unit', '3.6.2'
 gem 'timecop', '0.9.8'
+gem 'tzinfo', '2.0.6'
 gem 'yard', '0.9.36'
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -59,6 +59,8 @@ GEM
     test-unit (3.6.2)
       power_assert
     timecop (0.9.8)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
     unicode-display_width (2.5.0)
     yard (0.9.36)
 
@@ -78,6 +80,7 @@ DEPENDENCIES
   simplecov (= 0.22.0)
   test-unit (= 3.6.2)
   timecop (= 0.9.8)
+  tzinfo (= 2.0.6)
   yard (= 0.9.36)
 
 BUNDLED WITH

diff --git a/lib/locales/en/address.yml b/lib/locales/en/address.yml
@@ -1717,7 +1717,7 @@ en:
         - America/Godthab
         - Atlantic/South_Georgia
         - Atlantic/Azores
-        - Atlantic/Cabo_Verde
+        - Atlantic/Cape_Verde
         - Europe/Dublin
         - Europe/London
         - Europe/Lisbon

diff --git a/test/test_en_locale.rb b/test/test_en_locale.rb
@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require 'tzinfo'
 require_relative 'test_helper'
 
 class TestEnLocale < Test::Unit::TestCase
@@ -39,6 +40,13 @@ def test_values_trimmed
     check_hash(en_file)
   end
 
+  def test_en_timezones_are_valid_iana_identifiers
+    faker_time_zones = Faker::Address.translate('faker.address.time_zone')
+    iana_time_zones = TZInfo::Timezone.all_identifiers
+
+    assert_empty(faker_time_zones.difference(iana_time_zones), "Found a time zone that isn't a valid IANA time zone identifier")
+  end
+
   def check_hash(hash)
     hash.each { |key, value| check_value(value) unless key == 'separator' }
   end