Skip to content

Commit

Permalink
Workaround for cc-test-reporter with SimpleCov 0.18
Browse files Browse the repository at this point in the history
Closes #2241.

This PR fixes the following build error when using cc-test-reporter with
SimpleCov 0.18.

```console
Run export GIT_BRANCH="${GITHUB_REF/refs\/heads\//}"
Error: json: cannot unmarshal object into Go struct field input.coverage
of type []formatters.NullInt
Usage:
  cc-test-reporter after-build [flags]

(snip)

Global Flags:
  -d, --debug   run in debug mode

##[error]Process completed with exit code 255.
```

https://github.com/faker-ruby/faker/pull/2043/checks?check_run_id=750522010

This patch is a workaround until the following issue will be resolved.
codeclimate/test-reporter#418
  • Loading branch information
koic committed Mar 14, 2021
1 parent 6867cf5 commit 60988bb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Gemfile.lock
Expand Up @@ -59,7 +59,7 @@ DEPENDENCIES
pry (= 0.14.0)
rake (= 13.0.3)
rubocop (= 1.11.0)
simplecov (= 0.17.1)
simplecov (= 0.17.1, < 0.18)
test-unit (= 3.4.0)
timecop (= 0.9.4)
yard (= 0.9.26)
Expand Down
5 changes: 4 additions & 1 deletion faker.gemspec
Expand Up @@ -33,7 +33,10 @@ Gem::Specification.new do |spec|
spec.add_development_dependency('pry', '0.14.0')
spec.add_development_dependency('rake', '13.0.3')
spec.add_development_dependency('rubocop', '1.11.0')
spec.add_development_dependency('simplecov', '0.17.1')
# Workaround for cc-test-reporter with SimpleCov 0.18.
# Stop upgrading SimpleCov until the following issue will be resolved.
# https://github.com/codeclimate/test-reporter/issues/418
spec.add_development_dependency('simplecov', '0.17.1', '< 0.18')
spec.add_development_dependency('test-unit', '3.4.0')
spec.add_development_dependency('timecop', '0.9.4')
spec.add_development_dependency('yard', '0.9.26')
Expand Down

0 comments on commit 60988bb

Please sign in to comment.