Bump rubocop-minitest from 0.34.4 to 0.35.0 (#2918)

* Bump rubocop-minitest from 0.34.4 to 0.35.0 Bumps [rubocop-minitest](https://github.com/rubocop/rubocop-minitest) from 0.34.4 to 0.35.0. - [Release notes](https://github.com/rubocop/rubocop-minitest/releases) - [Changelog](https://github.com/rubocop/rubocop-minitest/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-minitest@v0.34.4...v0.35.0) --- updated-dependencies: - dependency-name: rubocop-minitest dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Run rubocop's autocorrectable command --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Stefanni Brasil <stefannibrasil@gmail.com>
faker-ruby · Mar 26, 2024 · 5b27fe4 · 5b27fe4
1 parent a21875f
commit 5b27fe4
Show file tree

Hide file tree

Showing 75 changed files with 1,197 additions and 1,197 deletions.
diff --git a/Gemfile b/Gemfile
@@ -10,7 +10,7 @@ gem 'minitest', '5.22.3'
 gem 'pry', '0.14.2'
 gem 'rake', '13.1.0'
 gem 'rubocop', '1.62.1'
-gem 'rubocop-minitest', '0.34.4'
+gem 'rubocop-minitest', '0.35.0'
 gem 'rubocop-rake', '0.6.0'
 gem 'simplecov', '0.22.0'
 gem 'test-unit', '3.6.2'

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -44,9 +44,9 @@ GEM
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.31.2)
       parser (>= 3.3.0.4)
-    rubocop-minitest (0.34.4)
-      rubocop (>= 1.39, < 2.0)
-      rubocop-ast (>= 1.30.0, < 2.0)
+    rubocop-minitest (0.35.0)
+      rubocop (>= 1.61, < 2.0)
+      rubocop-ast (>= 1.31.1, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
     ruby-progressbar (1.13.0)
@@ -73,7 +73,7 @@ DEPENDENCIES
   pry (= 0.14.2)
   rake (= 13.1.0)
   rubocop (= 1.62.1)
-  rubocop-minitest (= 0.34.4)
+  rubocop-minitest (= 0.35.0)
   rubocop-rake (= 0.6.0)
   simplecov (= 0.22.0)
   test-unit (= 3.6.2)

diff --git a/test/faker/default/test_array_sample_method_compat.rb b/test/faker/default/test_array_sample_method_compat.rb
@@ -37,7 +37,7 @@ def test_returns_an_array_with_integer_param
     source = %w[foo bar baz]
     result = source.sample(2)
 
-    assert result.is_a? Array
+    assert_kind_of Array, result
     assert_equal(2, result.length)
     assert_empty((result - source))
   end
@@ -46,12 +46,12 @@ def test_returns_source_array_with_integer_param_equal_or_bigger_than_source_len
     source = %w[foo bar]
     result = source.sample(2)
 
-    assert result.is_a? Array
+    assert_kind_of Array, result
     assert_predicate((source.sort <=> result.sort), :zero?)
 
     result = source.sample(3)
 
-    assert result.is_a? Array
+    assert_kind_of Array, result
     assert_predicate((source.sort <=> result.sort), :zero?)
   end
 

diff --git a/test/faker/default/test_faker_cannabis.rb b/test/faker/default/test_faker_cannabis.rb
@@ -51,16 +51,16 @@ def test_locales
     [nil, 'en', 'de'].each do |_locale_name|
       Faker::Config.locale = 'de'
 
-      assert Faker::Cannabis.strain.is_a? String
-      assert Faker::Cannabis.cannabinoid_abbreviation.is_a? String
-      assert Faker::Cannabis.cannabinoid.is_a? String
-      assert Faker::Cannabis.terpene.is_a? String
-      assert Faker::Cannabis.medical_use.is_a? String
-      assert Faker::Cannabis.health_benefit.is_a? String
-      assert Faker::Cannabis.category.is_a? String
-      assert Faker::Cannabis.type.is_a? String
-      assert Faker::Cannabis.buzzword.is_a? String
-      assert Faker::Cannabis.brand.is_a? String
+      assert_kind_of String, Faker::Cannabis.strain
+      assert_kind_of String, Faker::Cannabis.cannabinoid_abbreviation
+      assert_kind_of String, Faker::Cannabis.cannabinoid
+      assert_kind_of String, Faker::Cannabis.terpene
+      assert_kind_of String, Faker::Cannabis.medical_use
+      assert_kind_of String, Faker::Cannabis.health_benefit
+      assert_kind_of String, Faker::Cannabis.category
+      assert_kind_of String, Faker::Cannabis.type
+      assert_kind_of String, Faker::Cannabis.buzzword
+      assert_kind_of String, Faker::Cannabis.brand
     end
   end
 end
diff --git a/test/faker/default/test_faker_color.rb b/test/faker/default/test_faker_color.rb
@@ -63,7 +63,7 @@ def test_hsl_color
     assert_equal(3, @result.length)
 
     assert @result[0].between?(0, 360)
-    assert @result[0].is_a?(Integer)
+    assert_kind_of Integer, @result[0]
     assert @result[1].between?(0.0, 1.0)
     assert @result[2].between?(0.0, 1.0)
   end

diff --git a/test/faker/default/test_faker_commerce.rb b/test/faker/default/test_faker_commerce.rb
@@ -91,11 +91,11 @@ def test_price_with_srand
   end
 
   def test_price_is_float
-    assert @tester.price.is_a? Float
+    assert_kind_of Float, @tester.price
   end
 
   def test_when_as_string_is_true
-    assert @tester.price(range: 0..100.0, as_string: true).is_a?(String)
+    assert_kind_of String, @tester.price(range: 0..100.0, as_string: true)
     assert_includes @tester.price(range: 100..500.0, as_string: true), '.'
   end
 

diff --git a/test/faker/default/test_faker_construction.rb b/test/faker/default/test_faker_construction.rb
@@ -35,12 +35,12 @@ def test_locales
     [nil, 'en'].each do |locale_name|
       Faker::Config.locale = locale_name
 
-      assert Faker::Construction.material.is_a? String
-      assert Faker::Construction.subcontract_category.is_a? String
-      assert Faker::Construction.standard_cost_code.is_a? String
-      assert Faker::Construction.trade.is_a? String
-      assert Faker::Construction.role.is_a? String
-      assert Faker::Construction.heavy_equipment.is_a? String
+      assert_kind_of String, Faker::Construction.material
+      assert_kind_of String, Faker::Construction.subcontract_category
+      assert_kind_of String, Faker::Construction.standard_cost_code
+      assert_kind_of String, Faker::Construction.trade
+      assert_kind_of String, Faker::Construction.role
+      assert_kind_of String, Faker::Construction.heavy_equipment
     end
   end
 end
diff --git a/test/faker/default/test_faker_date.rb b/test/faker/default/test_faker_date.rb
@@ -88,7 +88,7 @@ def test_return_type
     random_between  = @tester.between(from: Date.today, to: Date.today + 5)
 
     [random_forward, random_backward, random_between].each do |result|
-      assert result.is_a?(Date), "Expected a Date object, but got #{result.class}"
+      assert_kind_of Date, result, "Expected a Date object, but got #{result.class}"
     end
   end
 

diff --git a/test/faker/default/test_faker_internet.rb b/test/faker/default/test_faker_internet.rb
@@ -19,8 +19,8 @@ def test_email_with_no_arguments
 
       domain_name, domain_suffix = domain.split('.')
 
-      assert name.is_a? String
-      assert domain_name.is_a? String
+      assert_kind_of String, name
+      assert_kind_of String, domain_name
       assert_includes(%w[example test], domain_suffix)
     end
   end
@@ -31,7 +31,7 @@ def test_email_name_with_non_permitted_characters
       domain_name, domain_suffix = domain.split('.')
 
       assert_equal('mart#n', name)
-      assert domain_name.is_a? String
+      assert_kind_of String, domain_name
       assert_includes(%w[example test], domain_suffix)
     end
   end
@@ -42,7 +42,7 @@ def test_email_with_separators
       domain_name, domain_suffix = domain.split('.')
 
       assert_match(/(jane\+doe|doe\+jane)/, name)
-      assert domain_name.is_a? String
+      assert_kind_of String, domain_name
       assert_includes(%w[example test], domain_suffix)
     end
   end
@@ -53,7 +53,7 @@ def test_email_with_domain_name_option_given
     name, domain = result.split('@')
     domain_name, domain_suffix = domain.split('.')
 
-    assert name.is_a? String
+    assert_kind_of String, name
     assert_equal('customdomain', domain_name)
     assert_includes(%w[example test], domain_suffix)
   end
@@ -62,7 +62,7 @@ def test_email_with_full_domain_option_given
     deterministically_verify -> { @tester.email(domain: 'customdomain.org') } do |result|
       name, domain = result.split('@')
 
-      assert name.is_a? String
+      assert_kind_of String, name
       assert_equal('customdomain.org', domain)
     end
   end
@@ -314,7 +314,7 @@ def test_deterministic_password_with_compatible_min_length_and_requirements
   def test_domain_name_without_subdomain
     domain_name, domain_suffix = @tester.domain_name.split('.')
 
-    assert domain_name.is_a? String
+    assert_kind_of String, domain_name
     assert_includes(%w[example test], domain_suffix)
   end
 
@@ -323,8 +323,8 @@ def test_domain_name_with_subdomain
       subdomain: true
     ).split('.')
 
-    assert domain_name.is_a? String
-    assert subdomain.is_a? String
+    assert_kind_of String, domain_name
+    assert_kind_of String, subdomain
     assert_includes(%w[example test], domain_suffix)
   end
 
@@ -334,7 +334,7 @@ def test_domain_name_with_subdomain_and_with_domain_name_option_given
       domain: 'customdomain'
     ).split('.')
 
-    assert subdomain.is_a? String
+    assert_kind_of String, subdomain
     assert_equal 'customdomain', domain_name
     assert_includes(%w[example test], domain_suffix)
   end
@@ -345,7 +345,7 @@ def test_domain_name_with_subdomain_and_with_full_domain_option_given
       domain: 'faker-ruby.org'
     ).split('.')
 
-    assert subdomain.is_a? String
+    assert_kind_of String, subdomain
     assert_equal 'faker-ruby', domain_name
     assert_equal 'org', domain_suffix
   end

diff --git a/test/faker/default/test_faker_lorem.rb b/test/faker/default/test_faker_lorem.rb
@@ -132,7 +132,7 @@ def test_words_with_large_count_params
   end
 
   def test_multibyte
-    assert @tester.multibyte.is_a? String
+    assert_kind_of String, @tester.multibyte
     assert_includes %w[😀 ❤ 😡], @tester.multibyte
   end
 

diff --git a/test/faker/default/test_faker_name.rb b/test/faker/default/test_faker_name.rb
@@ -20,15 +20,15 @@ def test_first_name
   end
 
   def test_male_first_name
-    assert @tester.male_first_name.is_a? String
+    assert_kind_of String, @tester.male_first_name
   end
 
   def test_female_first_name
-    assert @tester.female_first_name.is_a? String
+    assert_kind_of String, @tester.female_first_name
   end
 
   def test_neutral_first_name
-    assert @tester.neutral_first_name.is_a? String
+    assert_kind_of String, @tester.neutral_first_name
   end
 
   def test_middle_name

diff --git a/test/faker/default/test_faker_restaurant.rb b/test/faker/default/test_faker_restaurant.rb
@@ -8,18 +8,18 @@ def setup
   end
 
   def test_name
-    assert @tester.name.is_a?(String)
+    assert_kind_of String, @tester.name
   end
 
   def test_type
-    assert @tester.type.is_a?(String)
+    assert_kind_of String, @tester.type
   end
 
   def test_description
-    assert @tester.description.is_a?(String)
+    assert_kind_of String, @tester.description
   end
 
   def test_review
-    assert @tester.review.is_a?(String)
+    assert_kind_of String, @tester.review
   end
 end
diff --git a/test/faker/default/test_faker_string.rb b/test/faker/default/test_faker_string.rb
@@ -12,7 +12,7 @@ def teardown
   end
 
   def test_is_string
-    assert @tester.random.is_a?(String)
+    assert_kind_of String, @tester.random
   end
 
   def test_has_valid_encoding

diff --git a/test/faker/default/test_faker_time.rb b/test/faker/default/test_faker_time.rb
@@ -69,7 +69,7 @@ def test_return_types_are_time_objects
       random_between_with_time_args,
       random_forward
     ].each do |result|
-      assert result.is_a?(Time), "Expected a Time object, but got #{result.class}"
+      assert_kind_of Time, result, "Expected a Time object, but got #{result.class}"
     end
   end
 
@@ -86,7 +86,7 @@ def test_format
       random_forward  = @tester.forward(days: 30, period: period, format: format)
 
       [random_backward, random_between, random_between_dates, random_forward].each do |result|
-        assert result.is_a?(String), "Expected a String, but got #{result.class}"
+        assert_kind_of String, result, "Expected a String, but got #{result.class}"
         assert_nothing_raised 'Not a valid date string' do
           date_format = '%m/%d/%Y %I:%M %p'
           DateTime.strptime(result, date_format)

diff --git a/test/faker/default/test_faker_vehicle.rb b/test/faker/default/test_faker_vehicle.rb
@@ -114,7 +114,7 @@ def test_version
 
   def doors_condition(doors)
     assert_predicate doors, :positive?
-    assert doors.is_a?(Integer)
+    assert_kind_of Integer, doors
   end
 
   def valid_vin(vin)

diff --git a/test/faker/default/test_twitter.rb b/test/faker/default/test_twitter.rb
@@ -10,52 +10,52 @@ def setup
   def test_user
     user = @tester.user
 
-    assert user.is_a?(Hash)
+    assert_kind_of Hash, user
     assert_equal(41, user.keys.count)
-    assert user[:status].is_a?(Hash)
+    assert_kind_of Hash, user[:status]
     assert_nil user[:status][:user]
   end
 
   def test_user_with_email
     user = @tester.user(include_email: true)
 
-    assert user.is_a?(Hash)
+    assert_kind_of Hash, user
     assert_equal(42, user.keys.count)
-    assert user[:email].is_a?(String)
+    assert_kind_of String, user[:email]
   end
 
   def test_user_without_status
     user = @tester.user(include_status: false)
 
-    assert user.is_a?(Hash)
+    assert_kind_of Hash, user
     assert_equal(40, user.keys.count)
     assert_nil user[:status]
   end
 
   def test_status
     status = @tester.status
 
-    assert status.is_a?(Hash)
+    assert_kind_of Hash, status
     assert_equal(25, status.keys.count)
-    assert status[:entities].is_a?(Hash)
-    assert status[:user].is_a?(Hash)
+    assert_kind_of Hash, status[:entities]
+    assert_kind_of Hash, status[:user]
     assert_nil status[:user][:status]
   end
 
   def test_status_without_user
     status = @tester.status(include_user: false)
 
-    assert status.is_a?(Hash)
+    assert_kind_of Hash, status
     assert_equal(24, status.keys.count)
     assert_nil status[:user]
   end
 
   def test_status_with_photo
     status = @tester.status(include_photo: true)
 
-    assert status.is_a?(Hash)
+    assert_kind_of Hash, status
     assert_equal(25, status.keys.count)
-    assert status[:entities].is_a?(Hash)
+    assert_kind_of Hash, status[:entities]
     assert_equal(1, status[:entities][:media].count)
     assert_equal(10, status[:entities][:media].first.keys.count)
   end