Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: eslint report-unused-disable-directives #2097

Merged
merged 2 commits into from
Apr 26, 2023
Merged

chore: eslint report-unused-disable-directives #2097

merged 2 commits into from
Apr 26, 2023

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent labels Apr 26, 2023
@Shinigami92 Shinigami92 self-assigned this Apr 26, 2023
@Shinigami92 Shinigami92 requested a review from a team as a code owner April 26, 2023 09:37
@Shinigami92 Shinigami92 requested a review from a team April 26, 2023 09:37
@codecov
Copy link

codecov bot commented Apr 26, 2023 •
edited

Codecov Report

Merging #2097 (45e3eec) into next (3fc7bf1) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #2097   +/-   ##
=======================================
  Coverage   99.59%   99.59%           
=======================================
  Files        2567     2567           
  Lines      243364   243363    -1     
  Branches     1252     1252           
=======================================
+ Hits       242377   242379    +2     
+ Misses        960      957    -3     
  Partials       27       27
Impacted Files Coverage Δ
src/internal/deprecated.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

ST-DDT
ST-DDT previously approved these changes Apr 26, 2023
View reviewed changes
package.json Show resolved Hide resolved
ST-DDT
ST-DDT approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I havent tested this in the IDE but looks good to me.

xDivisionByZerox
xDivisionByZerox approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this one.

@xDivisionByZerox xDivisionByZerox added the c: infra Changes to our infrastructure or project setup label Apr 26, 2023
@Shinigami92 Shinigami92 requested a review from a team April 26, 2023 12:37
@Shinigami92 Shinigami92 merged commit c2b1408 into next Apr 26, 2023
17 checks passed
@Shinigami92 Shinigami92 deleted the chore-lint-report-unused-disable-directives branch April 26, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: chore PR that doesn't affect the runtime behavior c: infra Changes to our infrastructure or project setup p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v8.x
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Shinigami92 @ST-DDT @import-brain @xDivisionByZerox