Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(finance): branch code option in bic() #1378

Merged
merged 12 commits into from Sep 22, 2022
Merged

feat(finance): branch code option in bic() #1378

merged 12 commits into from Sep 22, 2022

Conversation

import-brain
Copy link
Member

closes #1158

@import-brain import-brain requested a review from a team September 18, 2022 15:08
@import-brain import-brain self-assigned this Sep 18, 2022
@import-brain import-brain added c: feature Request for new feature p: 1-normal Nothing urgent m: finance Something is referring to the finance module labels Sep 18, 2022
@import-brain import-brain added this to the v7 - Current Major milestone Sep 18, 2022
@import-brain import-brain marked this pull request as ready for review September 18, 2022 15:10
@import-brain import-brain requested a review from a team as a code owner September 18, 2022 15:10
@codecov
Copy link

codecov bot commented Sep 18, 2022 •
edited

Codecov Report

Merging #1378 (3fcb070) into main (ea8d873) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1378   +/-   ##
=======================================
  Coverage   99.62%   99.63%           
=======================================
  Files        2163     2163           
  Lines      241264   241275   +11     
  Branches     1014     1018    +4     
=======================================
+ Hits       240357   240392   +35     
+ Misses        886      862   -24     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/finance/index.ts 100.00% <100.00%> (ø)
src/modules/internet/user-agent.ts 88.09% <0.00%> (+6.34%) ⬆️

Shinigami92
Shinigami92 requested changes Sep 18, 2022
View reviewed changes
src/modules/finance/index.ts Outdated Show resolved Hide resolved
@import-brain import-brain changed the title feat(finance): branchCode option in bic() feat(finance): branch code option in bic() Sep 19, 2022
@Shinigami92
Copy link
Member

Tests dont pass

import-brain
import-brain commented Sep 20, 2022
View reviewed changes
test/finance.spec.ts Outdated Show resolved Hide resolved
@ST-DDT
Copy link
Member

ST-DDT commented Sep 20, 2022

Also: https://github.com/validatorjs/validator.js/blob/master/src/lib/isBIC.js

@import-brain
Copy link
Member Author

import-brain commented Sep 20, 2022 •
edited

Seems like validator.isBIC does not recognize XK (Kosovo) as a country code, it intermittently fails when XK is the country code

@ST-DDT
Copy link
Member

ST-DDT commented Sep 20, 2022

Seems like validator.isBIC does not recognize XK (Kosovo) as a country code, it intermittently fails when XK is the country code

Maybe report this to validatorjs for them to fix?

@import-brain
Copy link
Member Author

import-brain commented Sep 20, 2022 •
edited

Seems like validator.isBIC does not recognize XK (Kosovo) as a country code, it intermittently fails when XK is the country code

Maybe report this to validatorjs for them to fix?

validatorjs/validator.js#2045

@ST-DDT ST-DDT merged commit fe97c29 into main Sep 22, 2022
@ST-DDT ST-DDT deleted the feat/branch_code_option branch September 22, 2022 16:27
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
@import-brain @wael-fadlallah
feat(finance): branch code option in bic() (faker-js#1378)
923a957
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

Assignees

@import-brain import-brain

Labels
c: feature Request for new feature m: finance Something is referring to the finance module p: 1-normal Nothing urgent
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

Branch code option for SWIFT/BIC codes
3 participants
@import-brain @Shinigami92 @ST-DDT