Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(finance): use validator.js for bitcoin addresses #1375

Merged
merged 12 commits into from Sep 21, 2022
Merged

test(finance): use validator.js for bitcoin addresses #1375

merged 12 commits into from Sep 21, 2022

Conversation

Minozzzi
Copy link
Contributor

Fixes: #1184

@Minozzzi Minozzzi requested a review from a team as a code owner September 13, 2022 01:11
@Minozzzi Minozzzi mentioned this pull request Sep 13, 2022
Closed
@codecov
Copy link

codecov bot commented Sep 13, 2022 •
edited

Codecov Report

Merging #1375 (ff07e5a) into main (bdd380d) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1375   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files        2163     2163           
  Lines      241264   241264           
  Branches     1014     1014           
=======================================
  Hits       240357   240357           
  Misses        886      886           
  Partials       21       21
Impacted Files Coverage Δ
src/modules/finance/index.ts 100.00% <100.00%> (ø)

@import-brain import-brain added c: test m: finance Something is referring to the finance module labels Sep 13, 2022
@import-brain import-brain added this to the v7 - Current Major milestone Sep 13, 2022
@import-brain import-brain requested a review from a team September 13, 2022 01:40
Shinigami92
Shinigami92 requested changes Sep 13, 2022
View reviewed changes
pnpm-lock.yaml Outdated Show resolved Hide resolved
test/finance.spec.ts Outdated Show resolved Hide resolved
Minozzzi and others added 7 commits September 18, 2022 13:36
@Minozzzi
test(finance/bitcoinAddress): use toSatisfy instead toBeTruthy
3bd93c8
@Minozzzi
revert: remove pnpm-lock.yaml auto format
dbf8400
@Shinigami92 @Minozzzi
chore: switch discord link (faker-js#1377)
eb46f58
@renovate @Minozzzi
chore(deps): update pnpm to v7.12.0 (faker-js#1382)
8cf7808 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @Minozzzi
chore(deps): update vitest to ~0.23.4 (faker-js#1380)
acd689c 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @Minozzzi
chore(deps): update typescript-eslint to ~5.37.0 (faker-js#1383)
fa8a807 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @Minozzzi
chore(deps): update doc-dependencies (faker-js#1379)
701a0db 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@Minozzzi Minozzzi requested a review from a team September 20, 2022 21:38
@Shinigami92 Shinigami92 changed the title test(finance/bitcoinAddress): use validator.js to test generated data test(finance): use validator.js to test generated bitcoin addresses Sep 21, 2022
@Shinigami92 Shinigami92 changed the title test(finance): use validator.js to test generated bitcoin addresses test(finance): use validator.js for bitcoin addresses Sep 21, 2022
@Shinigami92 Shinigami92 merged commit ea8d873 into faker-js:main Sep 21, 2022
wael-fadlallah pushed a commit to wael-fadlallah/faker that referenced this pull request Oct 14, 2022
@Minozzzi @wael-fadlallah
test(finance): use validator.js for bitcoin addresses (faker-js#1375)
9b190a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox left review comments

@ST-DDT ST-DDT ST-DDT approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@Minozzzi Minozzzi

Labels
c: test m: finance Something is referring to the finance module
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

Generated bitcoin addresses should pass validators.isBtcAddress
5 participants
@Minozzzi @ST-DDT @Shinigami92 @import-brain @xDivisionByZerox