Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: localization #1364

Merged
merged 12 commits into from Sep 11, 2022
Merged

docs: localization #1364

merged 12 commits into from Sep 11, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Sep 10, 2022

closes #1322

Co-authored-by: Leyla Jähnig leyla.jaehnig@gmx.de
Co-authored-by: ST-DDT ST-DDT@gmx.de

@Shinigami92 Shinigami92 added the c: docs Improvements or additions to documentation label Sep 10, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone Sep 10, 2022
@Shinigami92 Shinigami92 self-assigned this Sep 10, 2022
@codecov
Copy link

codecov bot commented Sep 10, 2022

Codecov Report

Merging #1364 (1391356) into main (8db9d6e) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1364      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2163     2163              
  Lines      241264   241264              
  Branches     1015     1014       -1     
==========================================
- Hits       240364   240357       -7     
- Misses        879      886       +7     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 81.74% <0.00%> (-1.86%) ⬇️

Copy link
Member

@ST-DDT ST-DDT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a newline after each sentence to avoid 200+char long lines.
Please also make sure that you refer to Faker consistently (vs faker).
Languages are always capitalized.

docs/guide/locales.md Outdated Show resolved Hide resolved
docs/guide/locales.md Outdated Show resolved Hide resolved
docs/guide/locales.md Outdated Show resolved Hide resolved
@Shinigami92 Shinigami92 marked this pull request as ready for review September 10, 2022 13:12
@Shinigami92 Shinigami92 requested a review from a team September 10, 2022 13:12
@Shinigami92 Shinigami92 requested a review from a team as a code owner September 10, 2022 13:12
@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug labels Sep 10, 2022
@Shinigami92 Shinigami92 changed the title docs: locales docs: localization Sep 10, 2022
docs/guide/localization.md Outdated Show resolved Hide resolved
scripts/generateLocales.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Eric Cheng <ericcheng9316@gmail.com>
ST-DDT
ST-DDT previously approved these changes Sep 10, 2022
import-brain
import-brain previously approved these changes Sep 10, 2022
@ST-DDT ST-DDT requested review from a team September 11, 2022 12:51
@Shinigami92 Shinigami92 merged commit 907558b into main Sep 11, 2022
@import-brain import-brain deleted the docs-locales branch September 11, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Document how to use locales
4 participants