Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: e2e tests #1362

Merged
merged 9 commits into from Sep 9, 2022
Merged

test: e2e tests #1362

merged 9 commits into from Sep 9, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added c: docs Improvements or additions to documentation c: test labels Sep 9, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone Sep 9, 2022
@Shinigami92 Shinigami92 self-assigned this Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022 •
edited

Codecov Report

Merging #1362 (63a237c) into main (83b6142) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1362      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2163     2163              
  Lines      241264   241264              
  Branches     1015     1014       -1     
==========================================
- Hits       240364   240357       -7     
- Misses        879      886       +7     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/internet/user-agent.ts 81.74% <0.00%> (-1.86%) ⬇️

@ST-DDT ST-DDT linked an issue Sep 9, 2022 that may be closed by this pull request
Enable/Fix e2e tests for our api docs #367
Closed
@ST-DDT ST-DDT added p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug labels Sep 9, 2022
@Shinigami92 Shinigami92 marked this pull request as ready for review September 9, 2022 10:16
@Shinigami92 Shinigami92 requested a review from a team as a code owner September 9, 2022 10:16
@ST-DDT ST-DDT requested review from a team September 9, 2022 10:18
@Shinigami92 Shinigami92 merged commit 0c6e9b1 into main Sep 9, 2022
@Shinigami92 Shinigami92 deleted the docs-e2e-tests branch September 9, 2022 12:07
import-brain
import-brain reviewed Sep 9, 2022
View reviewed changes
Copy link
Member

@import-brain import-brain left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@import-brain import-brain import-brain left review comments

@ST-DDT ST-DDT ST-DDT approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels
c: docs Improvements or additions to documentation c: test p: 2-high Fix main branch s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

Enable/Fix e2e tests for our api docs
4 participants
@Shinigami92 @ST-DDT @import-brain @xDivisionByZerox