Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove obsolete test snapshots #1338

Merged
merged 2 commits into from Sep 7, 2022
Merged

chore: remove obsolete test snapshots #1338

merged 2 commits into from Sep 7, 2022

Conversation

ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Sep 6, 2022

Fixes
grafik

@ST-DDT ST-DDT added c: chore PR that doesn't affect the runtime behavior p: 1-normal Nothing urgent c: test s: accepted Accepted feature / Confirmed bug m: datatype Something is referring to the datatype module labels Sep 6, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Sep 6, 2022
@ST-DDT ST-DDT self-assigned this Sep 6, 2022
@ST-DDT ST-DDT requested a review from a team as a code owner September 6, 2022 19:02
@codecov
Copy link

codecov bot commented Sep 6, 2022 •
edited

Codecov Report

Merging #1338 (732cf19) into main (4a42d69) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1338      +/-   ##
==========================================
+ Coverage   99.62%   99.63%   +0.01%     
==========================================
  Files        2163     2163              
  Lines      240701   240701              
  Branches     1013     1018       +5     
==========================================
+ Hits       239793   239818      +25     
+ Misses        887      862      -25     
  Partials       21       21
Impacted Files Coverage Δ
src/modules/finance/index.ts 100.00% <0.00%> (+0.23%) ⬆️
src/modules/internet/user-agent.ts 88.09% <0.00%> (+6.34%) ⬆️

@ST-DDT ST-DDT requested a review from a team September 6, 2022 19:09
@ST-DDT ST-DDT enabled auto-merge (squash) September 6, 2022 19:11
@ST-DDT ST-DDT requested a review from a team September 6, 2022 19:11
@ST-DDT ST-DDT merged commit bf1ea09 into main Sep 7, 2022
@ST-DDT ST-DDT deleted the chore/remove-obsolete-snapshots branch September 7, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@ST-DDT ST-DDT

Labels
c: chore PR that doesn't affect the runtime behavior c: test m: datatype Something is referring to the datatype module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ST-DDT @Shinigami92 @xDivisionByZerox