Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(locale): add months, days and few other minor strings to es #1320

Merged
merged 7 commits into from Aug 31, 2022
Merged

feat(locale): add months, days and few other minor strings to es #1320

merged 7 commits into from Aug 31, 2022

Conversation

rasputino
Copy link
Contributor

Just adding some longer and composite names and last names for persons and a special character town name.

@rasputino rasputino requested a review from a team as a code owner August 30, 2022 20:17
ST-DDT
ST-DDT previously approved these changes Aug 30, 2022
View reviewed changes
@ST-DDT ST-DDT added c: locale Permutes locale definitions s: accepted Accepted feature / Confirmed bug m: person Something is referring to the person module labels Aug 30, 2022
@ST-DDT ST-DDT added this to the v7 - Current Major milestone Aug 30, 2022
@ST-DDT ST-DDT added the p: 1-normal Nothing urgent label Aug 30, 2022
@codecov
Copy link

codecov bot commented Aug 30, 2022 •
edited

Codecov Report

Merging #1320 (0ea89c2) into main (cc15d9e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
- Coverage   99.63%   99.62%   -0.01%     
==========================================
  Files        2160     2163       +3     
  Lines      240614   240701      +87     
  Branches     1018     1014       -4     
==========================================
+ Hits       239731   239794      +63     
- Misses        862      886      +24     
  Partials       21       21
Impacted Files Coverage Δ
src/locales/es/address/city_prefix.ts 100.00% <100.00%> (ø)
src/locales/es/date/index.ts 100.00% <100.00%> (ø)
src/locales/es/date/month.ts 100.00% <100.00%> (ø)
src/locales/es/date/weekday.ts 100.00% <100.00%> (ø)
src/locales/es/index.ts 100.00% <100.00%> (ø)
src/locales/es/internet/domain_suffix.ts 100.00% <100.00%> (ø)
src/locales/es/name/female_first_name.ts 100.00% <100.00%> (ø)
src/locales/es/name/first_name.ts 100.00% <100.00%> (ø)
src/locales/es/name/last_name.ts 100.00% <100.00%> (ø)
src/locales/es/name/male_first_name.ts 100.00% <100.00%> (ø)
... and 1 more

@rasputino
Update male_first_name.ts
2adcda6 
eslint corrections
@ST-DDT ST-DDT added m: location Something is referring to the location module m: internet Something is referring to the internet module labels Aug 30, 2022
ST-DDT
ST-DDT previously approved these changes Aug 30, 2022
View reviewed changes
@ST-DDT ST-DDT requested review from a team August 30, 2022 21:06
import-brain
import-brain previously approved these changes Aug 31, 2022
View reviewed changes
@rasputino rasputino dismissed stale reviews from import-brain and ST-DDT via a461846 August 31, 2022 08:00
ST-DDT
ST-DDT previously approved these changes Aug 31, 2022
View reviewed changes
pkuczynski
pkuczynski requested changes Aug 31, 2022
View reviewed changes
src/locales/es/date/weekday.ts Outdated Show resolved Hide resolved
@pkuczynski pkuczynski changed the title feat(locale): adding more complexity to es locales feat(locale:es): add months, days and few other minor strings Aug 31, 2022
@Shinigami92 Shinigami92 changed the title feat(locale:es): add months, days and few other minor strings feat(locale): add months, days and few other minor strings to es Aug 31, 2022
@rasputino
Update month.ts
a2aa045 
Removing wide_context as requested
@rasputino
Update weekday.ts
0ea89c2 
Removing wide_context as requested
@ST-DDT ST-DDT requested review from a team August 31, 2022 17:57
@ST-DDT ST-DDT merged commit ebb4e2c into faker-js:main Aug 31, 2022
@rasputino rasputino mentioned this pull request Sep 1, 2022
Open
@xDivisionByZerox xDivisionByZerox mentioned this pull request Sep 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkuczynski pkuczynski pkuczynski approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@import-brain import-brain import-brain approved these changes

Assignees

@rasputino rasputino

Labels
c: locale Permutes locale definitions m: internet Something is referring to the internet module m: location Something is referring to the location module m: person Something is referring to the person module p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Faker Roadmap
Status: Done
Milestone
v7 - Current Major
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rasputino @pkuczynski @ST-DDT @import-brain