refactor(helpers): deprecate repeatString #1299
Merged
+12
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDivisionByZerox
added
p: 1-normal
Codecov Report
@@ Coverage Diff @@
## main #1299 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2160 2160
Lines 240439 240444 +5
Branches 1007 1007
=======================================
+ Hits 239535 239547 +12
+ Misses 883 876 -7
Partials 21 21
|
ST-DDT
approved these changes
Aug 24, 2022
ejcheng
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates
faker.helpers.repeatString()in favor of the native supported String.prototype.repeat().