Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(company): move name formats to locales #1293

Merged
merged 7 commits into from Aug 22, 2022
Merged

feat(company): move name formats to locales #1293

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4540013
refactor(locales): rename company name to company name_patterns
Minozzzi Aug 22, 2022
47b3e46
feat(definitions/company): add name_patterns
Minozzzi Aug 22, 2022
1da9b48
refactor(modules/company/name): keep static patterns as a fallback
Minozzzi Aug 22, 2022
74cfa45
chore(locales/company): update locales
Minozzzi Aug 22, 2022
77a933f
refactor(modules/company/name): use ?? operator instead ternary
Minozzzi Aug 22, 2022
e8d769b
chore: lint files
Minozzzi Aug 22, 2022
ebcd6c1
Merge branch 'main' into refactor/company/formats
Shinigami92 Aug 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/modules/company/index.ts
View file
Open in desktop
Expand Up @@ -50,8 +50,7 @@ export class Company {
'{{name.lastName}} - {{name.lastName}}',
'{{name.lastName}}, {{name.lastName}} and {{name.lastName}}',
];
const localeFormats = this.faker.definitions.company.name_patterns;
const formats = localeFormats ? localeFormats : staticFormats;
const formats = this.faker.definitions.company.name_patterns ?? staticFormats;
Minozzzi marked this conversation as resolved.
Show resolved Hide resolved

if (typeof format !== 'number') {
format = this.faker.datatype.number(formats.length - 1);
Expand Down