Skip to content

docs: fix browser usage #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2022
Merged

docs: fix browser usage #1249

merged 1 commit into from
Aug 10, 2022

Conversation

Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Aug 9, 2022

our docs point to some invalid usage
since v6 we only support using type module for browser
this supersede #1001

tested it locally with a static index.html

@Shinigami92 Shinigami92 added the c: docs Improvements or additions to documentation label Aug 9, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone Aug 9, 2022
@Shinigami92 Shinigami92 self-assigned this Aug 9, 2022
@Shinigami92 Shinigami92 requested a review from a team August 9, 2022 16:34
@Shinigami92 Shinigami92 requested a review from a team as a code owner August 9, 2022 16:34
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #1249 (15a2e9a) into main (dddebeb) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
- Coverage   99.62%   99.62%   -0.01%     
==========================================
  Files        2156     2156              
  Lines      236988   236988              
  Branches     1003     1002       -1     
==========================================
- Hits       236100   236099       -1     
- Misses        867      868       +1     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/finance/index.ts 99.76% <0.00%> (-0.24%) ⬇️

@Shinigami92 Shinigami92 requested review from a team August 9, 2022 17:01
@Shinigami92 Shinigami92 merged commit 85a94e1 into main Aug 10, 2022
@Shinigami92 Shinigami92 deleted the fix-browser-usage-docs branch August 10, 2022 03:12
@Shinigami92 Shinigami92 mentioned this pull request Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: docs Improvements or additions to documentation
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants