Skip to content

test: fix cypress doc tests #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2022
Merged

test: fix cypress doc tests #1088

merged 3 commits into from
Jun 23, 2022

Conversation

Shinigami92
Copy link
Member

No description provided.

@Shinigami92 Shinigami92 added p: 1-normal Nothing urgent c: test s: accepted Accepted feature / Confirmed bug labels Jun 18, 2022
@Shinigami92 Shinigami92 added this to the v7 - Current Major milestone Jun 18, 2022
@Shinigami92 Shinigami92 requested a review from JessicaSachs June 18, 2022 09:38
@Shinigami92 Shinigami92 requested a review from a team as a code owner June 18, 2022 09:38
@Shinigami92 Shinigami92 self-assigned this Jun 18, 2022
@codecov
Copy link

codecov bot commented Jun 18, 2022

Codecov Report

Merging #1088 (6ea5303) into main (74ad512) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1088      +/-   ##
==========================================
- Coverage   99.64%   99.64%   -0.01%     
==========================================
  Files        2146     2146              
  Lines      230393   230393              
  Branches      978      977       -1     
==========================================
- Hits       229580   229577       -3     
- Misses        792      795       +3     
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/finance/index.ts 99.31% <0.00%> (-0.69%) ⬇️

@ST-DDT
Copy link
Member

ST-DDT commented Jun 18, 2022

The e2e tests failed both in the terminal and in electron until I added a wait.
However, since I started to write this comment the failure is no longer reproducible both with and without the wait😕 .

I still get this error/message though:

Missing baseUrl in compilerOptions. tsconfig-paths will be skipped

@JessicaSachs
Copy link
Contributor

JessicaSachs commented Jun 19, 2022

Ignore the error message... known issue.

I'm concerned that there's a difference between 9.x and 10.x though. This should have been a clean upgrade. We didn't do many changes in 10.x for E2E testing.

@Shinigami92 Shinigami92 requested review from xDivisionByZerox and a team June 23, 2022 13:14

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@Shinigami92 Shinigami92 enabled auto-merge (squash) June 23, 2022 13:50
@Shinigami92 Shinigami92 merged commit 6e06418 into main Jun 23, 2022
@ST-DDT ST-DDT deleted the fix-cypress-update-to-v10 branch June 23, 2022 14:00
Minozzzi pushed a commit to Minozzzi/faker that referenced this pull request Jul 19, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: test p: 1-normal Nothing urgent s: accepted Accepted feature / Confirmed bug
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants