fix: remove duplicated BRANDS input of setProps in UACHData func #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisalman
requested changes
Jul 30, 2023
chenyuan-new
force-pushed
the
fix/rm-duplicate-BRANDS
branch
from
f4e7227
to
6a3cd59
Compare
@faisalman Thanks for your comment! I've rebased my branch to develop, please review the PR |
faisalman
approved these changes
Aug 8, 2023
faisalman
pushed a commit
that referenced
this pull request
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just remove duplicated BRANDS input of setProps in UACHData func and it passes all the test